Re: [PATCH 2/2] x86, paravirt: Fix bool return type for PVOP_CALL

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] x86, paravirt: Fix bool return type for PVOP_CALL
Date	2016-12-08 18:00 +0100
Message-ID	<sMad4-8vg-15@gated-at.bofh.it> (permalink)
References	<sM97k-7Se-15@gated-at.bofh.it> <sM97l-7Se-75@gated-at.bofh.it> <sMa3n-8rP-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Dec 09, 2016 at 12:40:35AM +0800, Pan Xinhui wrote:
> 
> hi, Peter
> 	I think I know the point.
> 
> then could we just let __eax rettype(here is bool), not unsigned long?
> I does not do tests for my thoughts.
> 
> @@ -461,7 +461,9 @@ int paravirt_disable_iospace(void);
>  #define PVOP_VCALL_ARGS                                                        \
>         unsigned long __eax = __eax, __edx = __edx, __ecx = __ecx;      \
>         register void *__sp asm("esp")
> -#define PVOP_CALL_ARGS                 PVOP_VCALL_ARGS
> +#define PVOP_CALL_ARGS 					\
> +       rettype __eax = __eax, __edx = __edx, __ecx = __ecx;    \
> +       register void *__sp asm("esp")

Doesn't work on i386 where eax is also an argument register.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Fix paravirt fail Peter Zijlstra <peterz@infradead.org> - 2016-12-08 16:50 +0100
  [PATCH 1/2] x86,paravirt: Fix native_patch() Peter Zijlstra <peterz@infradead.org> - 2016-12-08 16:50 +0100
  [PATCH 2/2] x86, paravirt: Fix bool return type for PVOP_CALL Peter Zijlstra <peterz@infradead.org> - 2016-12-08 16:50 +0100
    Re: [PATCH 2/2] x86, paravirt: Fix bool return type for PVOP_CALL Pan Xinhui <xinhui@linux.vnet.ibm.com> - 2016-12-08 17:50 +0100
      Re: [PATCH 2/2] x86, paravirt: Fix bool return type for PVOP_CALL Peter Zijlstra <peterz@infradead.org> - 2016-12-08 18:00 +0100

csiph-web