Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1538756
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 5/8] efi: Get the secure boot status [ver #5] |
| Date | 2016-12-08 18:40 +0100 |
| Message-ID | <sMaPN-vZ-55@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <sM0Qq-2Lg-1@gated-at.bofh.it> <sLKiB-yB-5@gated-at.bofh.it> <sLKiB-yB-3@gated-at.bofh.it> <sM25P-3Kk-5@gated-at.bofh.it> <sM6j8-6ce-3@gated-at.bofh.it> |
| Organization | Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 |
Lukas Wunner <lukas@wunner.de> wrote: > > +out_efi_err: > > + pr_efi_err(sys_table_arg, "Could not determine UEFI Secure Boot status.\n"); > > + if (status == EFI_NOT_FOUND) > > + return efi_secureboot_mode_disabled; > > + return efi_secureboot_mode_unknown; > > +} > > In the out_efi_err path, the if-statement needs to come before the > pr_efi_err() call. Otherwise it would be a change of behaviour for > ARM to what we have now. As I understand it, if the BIOS is an EFI BIOS, these variables must exist - in which case I would argue that the pr_efi_err-statement should be before the if-statement. David
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 5/8] efi: Get the secure boot status [ver #5] David Howells <dhowells@redhat.com> - 2016-12-07 14:20 +0100
Re: [PATCH 5/8] efi: Get the secure boot status [ver #5] Lukas Wunner <lukas@wunner.de> - 2016-12-08 08:00 +0100
Re: [PATCH 5/8] efi: Get the secure boot status [ver #5] David Howells <dhowells@redhat.com> - 2016-12-08 09:20 +0100
Re: [PATCH 5/8] efi: Get the secure boot status [ver #5] Lukas Wunner <lukas@wunner.de> - 2016-12-08 13:50 +0100
Re: [PATCH 5/8] efi: Get the secure boot status [ver #5] David Howells <dhowells@redhat.com> - 2016-12-08 18:40 +0100
Re: [PATCH 5/8] efi: Get the secure boot status [ver #5] Lukas Wunner <lukas@wunner.de> - 2016-12-09 01:40 +0100
csiph-web