Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1539919

Re: [media] bt8xx: One function call less in bttv_input_init() after error detection

Show all headers | View raw

> kfree() is safe to call on a NULL pointer.

This is true.


> Despite that, you have found several instances of similar constructs:

Yes. - Special source code search pattern can point such places out
for further considerations.


> Didn't it occur to you that maybe those constructs are fine the way
> they are and this is the idiomatic way to write that kind of code?

Such a programming approach might look convenient. - I would prefer
a safer coding style for the corresponding exception handling.


> Why are you submitting patches implementing changes that have already
> been rejected?

The feedback to my update mixture is varying between acceptance and
disagreements as usual.


> Judging from your recent submissions, it seems that this process is not
> working well for you. I'm probably not the only one that is wonderign
> what are you trying to obtain with your patch submissions, other than
> having your name in the git log.

I am picking some change possibilities up in the hope of related
software improvements.

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] [media] bt8xx: Fine-tuning for three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-10 21:50 +0100
  [PATCH 1/4] [media] bt8xx: One function call less in  bttv_input_init() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-10 21:50 +0100
    Re: [PATCH 1/4] [media] bt8xx: One function call less in  bttv_input_init() after error detection Daniele Nicolodi <daniele@grinta.net> - 2016-12-10 22:40 +0100
      Re: [media] bt8xx: One function call less in bttv_input_init() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-10 23:20 +0100
        Re: [media] bt8xx: One function call less in bttv_input_init() after  error detection Daniele Nicolodi <daniele@grinta.net> - 2016-12-11 23:00 +0100
          Re: [media] bt8xx: One function call less in bttv_input_init() after  error detection Daniele Nicolodi <daniele@grinta.net> - 2016-12-12 08:40 +0100
            Re: [media] bt8xx: One function call less in bttv_input_init() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-12 18:20 +0100
              Re: [media] bt8xx: One function call less in bttv_input_init() after  error detection Daniele Nicolodi <daniele@grinta.net> - 2016-12-12 19:00 +0100
            Re: Clarification for acceptance statistics? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-12 19:10 +0100
              Re: Clarification for acceptance statistics? Daniele Nicolodi <daniele@grinta.net> - 2016-12-12 22:10 +0100
                Re: Clarification for acceptance statistics? SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-12 23:20 +0100
                Re: Clarification for acceptance statistics? Daniele Nicolodi <daniele@grinta.net> - 2016-12-13 00:20 +0100
            Re: [media] bt8xx: One function call less in bttv_input_init() after  error detection Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-12 20:20 +0100
          Re: [media] bt8xx: One function call less in bttv_input_init() after  error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-12 08:40 +0100
  [PATCH 4/4] [media] bt8xx: Less function calls in dst_ca_ioctl()  after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-10 22:00 +0100
  [PATCH 3/4] [media] bt8xx: Delete unnecessary variable  initialisations in ca_send_message() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-10 22:00 +0100
  [PATCH 2/4] [media] bt8xx: Delete two error messages for a failed  memory allocation SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-10 22:00 +0100

csiph-web