Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1539866

Re: [PATCH] iio: adc: max1027: allocate DMA-safe buffer

Show all headers | View raw

On 09/12/16 10:24, Marcus Folkesson wrote:
> The buffer needs to be DMA-safe when used with spi_read()
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Please read the documentation in include/linux/gfp.h about GFP_DMA.

Specifically:
220  * GFP_DMA exists for historical reasons and should be avoided where possible.
221  *   The flags indicates that the caller requires that the lowest zone be
222  *   used (ZONE_DMA or 16M on x86-64). Ideally, this would be removed but
223  *   it would require careful auditing as some users really require it and
224  *   others use the flag to avoid lowmem reserves in ZONE_DMA and treat the
225  *   lowest zone as a type of emergency reserve.

Seems unlikely this applies!  This caught me by surprise as I didn't even know
that flag existed - hence I went digging.

Jonathan
> ---
>  drivers/iio/adc/max1027.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c
> index 712fbd2b1f16..ff1f1f15a873 100644
> --- a/drivers/iio/adc/max1027.c
> +++ b/drivers/iio/adc/max1027.c
> @@ -435,7 +435,7 @@ static int max1027_probe(struct spi_device *spi)
>  
>  	st->buffer = devm_kmalloc(&indio_dev->dev,
>  				  indio_dev->num_channels * 2,
> -				  GFP_KERNEL);
> +				  GFP_KERNEL | GFP_DMA);
>  	if (st->buffer == NULL) {
>  		dev_err(&indio_dev->dev, "Can't allocate buffer\n");
>  		return -ENOMEM;
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iio: adc: max1027: allocate DMA-safe buffer Marcus Folkesson <marcus.folkesson@gmail.com> - 2016-12-09 11:40 +0100
  Re: [PATCH] iio: adc: max1027: allocate DMA-safe buffer Jonathan Cameron <jic23@kernel.org> - 2016-12-10 18:40 +0100
    Re: [PATCH] iio: adc: max1027: allocate DMA-safe buffer Marcus Folkesson <marcus.folkesson@gmail.com> - 2016-12-10 22:00 +0100
      Re: [PATCH] iio: adc: max1027: allocate DMA-safe buffer Jonathan Cameron <jic23@kernel.org> - 2016-12-11 16:10 +0100
      Re: [PATCH] iio: adc: max1027: allocate DMA-safe buffer Lars-Peter Clausen <lars@metafoo.de> - 2016-12-12 18:40 +0100

csiph-web