Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1539855

Could we have request_firmware_nowait with FW_OPT_NO_WARN?

Show all headers | View raw

Hi,

In brcmfmac we use request_firmware_nowait and if fetching firmware
with NVRAM variables fails then we try to fallback to the platform one
(see brcmf_fw_request_code_done & brcmf_fw_request_nvram_done).

Some problem for us is that on devices with platform NVRAM we get this error:
Direct firmware load for brcm/brcmfmac43602-pcie.txt failed with error -2
(which is harmless if getting platform NVRAM succeeds). This error is
quite confusing for users. They think something went wrong, they
expect problems & they report it back to us. Obviously I don't want
ugly hacks like:
pr_info("Got platform NVRAM, ignore above error\n");

So it would be nice to have version of request_firmware_nowait with
FW_OPT_NO_WARN. If requesting firmware NVRAM fails *and* getting
platform NVRAM fails, then I could to print error on my own.
Does it make sense? Can you see a point of my request?

Do you have any suggestion for this? If and how I could proceed with
implementation?

request_firmware_nowait already has "bool uevent" argument, I don't
want it to have argument per every available option. I was thinking
about moving FW_OPT_* defines to the include/linux/firmware.h but I'm
not sure if it's OK as they depend on:
CONFIG_FW_LOADER_USER_HELPER
and
CONFIG_FW_LOADER_USER_HELPER_FALLBACK
With defines placed in firmware.h I could replace "bool uevent" with
"unsigned int opt_flags".
Does it sound like a good plan? Or do you have any better idea?

-- 
Rafał

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Could we have request_firmware_nowait with FW_OPT_NO_WARN? Rafał Miłecki <zajec5@gmail.com> - 2016-12-10 17:00 +0100
  Re: Could we have request_firmware_nowait with FW_OPT_NO_WARN? Johannes Berg <johannes@sipsolutions.net> - 2016-12-12 09:20 +0100
    Re: Could we have request_firmware_nowait with FW_OPT_NO_WARN? Rafał Miłecki <zajec5@gmail.com> - 2016-12-12 09:40 +0100
      Re: Could we have request_firmware_nowait with FW_OPT_NO_WARN? Arend Van Spriel <arend.vanspriel@broadcom.com> - 2016-12-12 10:30 +0100
        Re: Could we have request_firmware_nowait with FW_OPT_NO_WARN? Rafał Miłecki <zajec5@gmail.com> - 2016-12-12 11:00 +0100
          Re: Could we have request_firmware_nowait with FW_OPT_NO_WARN? "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-12-12 15:10 +0100
            Re: Could we have request_firmware_nowait with FW_OPT_NO_WARN? Rafał Miłecki <zajec5@gmail.com> - 2016-12-12 15:20 +0100
      Re: Could we have request_firmware_nowait with FW_OPT_NO_WARN? Kalle Valo <kvalo@codeaurora.org> - 2016-12-12 12:50 +0100
  Re: Could we have request_firmware_nowait with FW_OPT_NO_WARN? "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-12-12 15:20 +0100

csiph-web