Re: [PATCH 2/2] USB: OHCI: pxa27x:fix code errors

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] USB: OHCI: pxa27x:fix code errors
Date	2016-12-10 15:10 +0100
Message-ID	<sMQvD-3gO-17@gated-at.bofh.it> (permalink)
References	<sMQvD-3gO-19@gated-at.bofh.it> <sMQvD-3gO-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Dec 10, 2016 at 01:13:28AM +0000, csmanjuvijay@gmail.com wrote:
> From: Manjunath Goudar <csmanjuvijay@gmail.com>
> 
> This patch will fix the checkpatch.pl following errors:
> 
> ERROR: space prohibited after that open parenthesis '('
> ERROR: space prohibited before that close parenthesis ')'
> 
> Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/usb/host/ohci-pxa27x.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c
> index c73e1ae..0f33583 100644
> --- a/drivers/usb/host/ohci-pxa27x.c
> +++ b/drivers/usb/host/ohci-pxa27x.c
> @@ -158,9 +158,9 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode)
>  		uhcrhdb |= (0x7<<17);
>  		break;
>  	default:
> -		printk( KERN_ERR
> +		printk(KERN_ERR
>  			"Invalid mode %d, set to non-power switch mode.\n",
> -			mode );
> +			mode);

Fix this properly and use dev_err() in a way that actually builds
properly this time.

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] USB: OHCI: pxa27x:fix code errors Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-10 15:10 +0100

csiph-web