Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1539738

Re: [PATCH 0/4] x86: Trust firmware a bit more about presence of 8042

Show all headers | View raw

Hi Dmitry,

On Fri, Dec 09, 2016 at 12:57:37PM -0800, Dmitry Torokhov wrote:
> Hi,
> 
> Historically we did not trust PNP data regarding keyboard controllers on
> X86, but more and more boards get upset with us if they try to tell us that
> there is no keyboard controller and we still go and try to poke at where we
> think it might be. To work around this issue let's have a bit more faith in
> BIOS data, and if [lack] of PNP devices for mouse and keyboard matches whet
> firmware (basically ACPI FADT) tells us, let's abort i8042 probe.
> 
> We add a new flag (enum) to x86_platform.legacy structure so we can
> distinguish between cases where platform/subarch never has 8042 (such as
> MID platform) and cases where firmware says that it is not there, so that
> i8042 driver can either abort immediately or go and check for presence of
> PNP devices. We also remove x86_platform.i8042_detect() as it is no longer
> used (platforms can set value of x86_platform.legacy.i8042 as needed in
> quirks).
> 
> If you are OK with arch/x86 changes please apply together with the input
> part.

Looks very good, better than my initial idea of adding more code into i8042_detect.

Acked-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

> 
> Thanks,
> Dmitry
> 
> Dmitry Torokhov (4):
>   x86/init: add i8042 state to the platform data
>   Input: i8042 - trust firmware a bit more when probing on X86
>   x86/init: remove i8042_detect() form platform ops
>   x86/init: fix a couple typos in arch/x86/include/asm/x86_init.h
> 
>  arch/x86/include/asm/x86_init.h         | 26 +++++++++++++++++++++-----
>  arch/x86/kernel/acpi/boot.c             |  7 +++++++
>  arch/x86/kernel/platform-quirks.c       |  5 +++++
>  arch/x86/kernel/x86_init.c              |  2 --
>  arch/x86/platform/ce4100/ce4100.c       |  6 ------
>  arch/x86/platform/intel-mid/intel-mid.c |  7 -------
>  drivers/input/serio/i8042-x86ia64io.h   | 10 +++++++---
>  7 files changed, 40 insertions(+), 23 deletions(-)
> 
> -- 
> 2.8.0.rc3.226.g39d4020
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] x86: Trust firmware a bit more about presence of 8042 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-09 22:00 +0100
  [PATCH 4/4] x86/init: fix a couple typos in arch/x86/include/asm/x86_init.h Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-09 22:00 +0100
    [tip:x86/urgent] x86/init: Fix a couple of comment typos tip-bot for Dmitry Torokhov <tipbot@zytor.com> - 2016-12-19 11:50 +0100
  [PATCH 3/4] x86/init: remove i8042_detect() form platform ops Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-09 22:00 +0100
    [tip:x86/urgent] x86/init: Remove i8042_detect() from platform ops tip-bot for Dmitry Torokhov <tipbot@zytor.com> - 2016-12-19 11:50 +0100
  [PATCH 2/4] Input: i8042 - trust firmware a bit more when probing on X86 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-12-09 22:00 +0100
    [tip:x86/urgent] Input: i8042 - Trust firmware a bit more when  probing on X86 tip-bot for Dmitry Torokhov <tipbot@zytor.com> - 2016-12-19 11:50 +0100
  Re: [PATCH 0/4] x86: Trust firmware a bit more about presence of 8042 Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2016-12-10 01:00 +0100
  Re: [PATCH 0/4] x86: Trust firmware a bit more about presence of 8042 Takashi Iwai <tiwai@suse.de> - 2016-12-12 15:40 +0100

csiph-web