Re: [PATCH v6 1/2] sparc: fix a building error reported by kbuild

From	Sam Ravnborg <sam@ravnborg.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 1/2] sparc: fix a building error reported by kbuild
Date	2016-12-09 23:00 +0100
Message-ID	<sMBmV-8vz-1@gated-at.bofh.it> (permalink)
References	<sLYEV-1lh-7@gated-at.bofh.it> <sLYEV-1lh-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Gonglei.

On Thu, Dec 08, 2016 at 12:37:08PM +0800, Gonglei wrote:
> >> arch/sparc/include/asm/topology_64.h:44:44:
> error: implicit declaration of function 'cpu_data'
> [-Werror=implicit-function-declaration]
> 
>  #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id)
>                                                ^
> Let's include cpudata.h in topology_64.h.
> 
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Suggested-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> ---
>  arch/sparc/include/asm/topology_64.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
> index 7b4898a..2255430 100644
> --- a/arch/sparc/include/asm/topology_64.h
> +++ b/arch/sparc/include/asm/topology_64.h
> @@ -4,6 +4,7 @@
>  #ifdef CONFIG_NUMA
>  
>  #include <asm/mmzone.h>
> +#include <asm/cpudata.h>

Nitpick - if you are going to resend this patch, then please
order the two includes in alphabetic order.

For two includes this looks like bikeshedding, but when we add
more having them in a defined arder prevents merge conflicts.
And makes it readable too.

We also sometimes order the includes with the longest lines topmost,
and lines with the ame length are ordered alphabetically.
But this is not seen so often.

	Sam

Thread

[PATCH v6 1/2] sparc: fix a building error reported by kbuild Gonglei <arei.gonglei@huawei.com> - 2016-12-08 05:40 +0100
  Re: [PATCH v6 1/2] sparc: fix a building error reported by kbuild Sam Ravnborg <sam@ravnborg.org> - 2016-12-09 23:00 +0100
    RE: [PATCH v6 1/2] sparc: fix a building error reported by kbuild "Gonglei (Arei)" <arei.gonglei@huawei.com> - 2016-12-10 09:50 +0100

csiph-web