Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks.

From	Takashi Iwai <tiwai@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks.
Date	2016-12-09 22:00 +0100
Message-ID	<sMAqS-7Wr-25@gated-at.bofh.it> (permalink)
References	<sMli9-7cd-3@gated-at.bofh.it> <sMqBc-24F-29@gated-at.bofh.it> <sMAqS-7Wr-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 09 Dec 2016 21:35:17 +0100,
Con Kolivas wrote:
> 
> On Friday, 9 December 2016 11:22:15 AM AEDT Takashi Iwai wrote:
> > On Fri, 09 Dec 2016 05:15:57 +0100,
> > 
> > Con Kolivas wrote:
> > > The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the
> > > following warning.
> > > 
> > > [    6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
> > > cval->res is probably wrong.
> > > [    6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
> > > 4608/7680/1
> > > 
> > > Adding it to the list of devices in volume_control_quirks makes it work
> > > properly, fixing related typo.
> > > 
> > > Signed-off-by: Con Kolivas <kernel@kolivas.org>
> > 
> > Applied (with Cc to stable), thanks.
> 
> (Apologies for google mail defaulting to html, resending with a proper mail 
> client)
> 
> You're welcome. As there appear to be a lot of these devices from the same 
> manufacturer with the same error, and there are likely a lot of devices out 
> there that are missed from this whitelist, do you think it would be worthwhile 
> changing the code to detect the combination of unlikely big volume range and 
> usb vendor of 0x046d and automatically try using the volume_control_quirk on 
> them instead of a discrete whitelist?

Yeah, it sounds like a good idea!


thanks,

Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to  volume_control_quirks. Con Kolivas <con@kolivas.org> - 2016-12-09 05:50 +0100
  Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to  volume_control_quirks. Takashi Iwai <tiwai@suse.de> - 2016-12-09 11:30 +0100
    Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to  volume_control_quirks. Con Kolivas <kernel@kolivas.org> - 2016-12-09 22:00 +0100
      Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to  volume_control_quirks. Takashi Iwai <tiwai@suse.de> - 2016-12-09 22:00 +0100

csiph-web