Re: [PATCH 3/3] pciehp: Fix race condition handling surprise link-down

From	"Raj, Ashok" <ashok.raj@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] pciehp: Fix race condition handling surprise link-down
Date	2016-12-09 22:20 +0100
Message-ID	<sMAKe-8id-43@gated-at.bofh.it> (permalink)
References	(2 earlier) <sLU8i-6PU-19@gated-at.bofh.it> <sLUhY-6TP-7@gated-at.bofh.it> <sM8Ei-7HX-23@gated-at.bofh.it> <sMawp-pF-3@gated-at.bofh.it> <sMb97-Ct-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Bjorn

Thanks. I have resent the last patch again with consistent lock usage as you
had requested.

I did attempt to make things a bit more easier to understand in one my
earlier experiments, but that resulted in very substantial changes. 
Certainly something we should look in future to make the state machine 
more robust.

Cheers,
Ashok

On Thu, Dec 08, 2016 at 11:50:09AM -0600, Bjorn Helgaas wrote:
> > Yes, the alloc_ordered_workqueue is what I had in mind, though switching
> > to that is not as simple as calling the different API. I am looking into
> > that for longer term, but for the incremental fix, do you think we can
> > go forward with Raj's proposal?
> 
> I'd like to at least see a consistent locking strategy for protecting
> p_slot->state.  All the existing updates are protected by
> p_slot->lock, but the one Raj is adding is protected by
> p_slot->hotplug_lock.
> 
> Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] pciehp: Fix race condition handling surprise  link-down Bjorn Helgaas <helgaas@kernel.org> - 2016-12-08 00:50 +0100
  Re: [PATCH 3/3] pciehp: Fix race condition handling surprise  link-down Keith Busch <keith.busch@intel.com> - 2016-12-08 01:00 +0100
    Re: [PATCH 3/3] pciehp: Fix race condition handling surprise  link-down Bjorn Helgaas <helgaas@kernel.org> - 2016-12-08 16:20 +0100
      Re: [PATCH 3/3] pciehp: Fix race condition handling surprise  link-down Keith Busch <keith.busch@intel.com> - 2016-12-08 18:20 +0100
        Re: [PATCH 3/3] pciehp: Fix race condition handling surprise  link-down Bjorn Helgaas <helgaas@kernel.org> - 2016-12-08 19:00 +0100
          Re: [PATCH 3/3] pciehp: Fix race condition handling surprise  link-down "Raj, Ashok" <ashok.raj@intel.com> - 2016-12-09 22:20 +0100

csiph-web