Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1538585

Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7

From Jesper Dangaard Brouer <brouer@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7
Date 2016-12-08 15:50 +0100
Message-ID <sM8bf-7j1-13@gated-at.bofh.it> (permalink)
References (5 earlier) <sLTOV-6J2-19@gated-at.bofh.it> <sM2fv-3Ni-17@gated-at.bofh.it> <sM31T-4kE-21@gated-at.bofh.it> <sM4qZ-54M-3@gated-at.bofh.it> <sM4Km-5qs-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, 8 Dec 2016 11:06:56 +0000
Mel Gorman <mgorman@techsingularity.net> wrote:

> On Thu, Dec 08, 2016 at 11:43:08AM +0100, Jesper Dangaard Brouer wrote:
> > > That's expected. In the initial sniff-test, I saw negligible packet loss.
> > > I'm waiting to see what the full set of network tests look like before
> > > doing any further adjustments.  
> > 
> > For netperf I will not recommend adjusting the global default
> > /proc/sys/net/core/rmem_default as netperf have means of adjusting this
> > value from the application (which were the options you setup too low
> > and just removed). I think you should keep this as the default for now
> > (unless Eric says something else), as this should cover most users.
> >   
> 
> Ok, the current state is that buffer sizes are only set for netperf
> UDP_STREAM and only when running over a real network. The values selected
> were specific to the network I had available so milage may vary.
> localhost is left at the defaults.

Looks like you made a mistake when re-implementing using buffer sizes
for netperf. See patch below signature.

Besides I think you misunderstood me, you can adjust:
 sysctl net.core.rmem_max
 sysctl net.core.wmem_max

And you should if you plan to use/set 851968 as socket size for UDP
remote tests, else you will be limited to the "max" values (212992 well
actually 425984 2x default value, for reasons I cannot remember)


https://github.com/gormanm/mmtests/commit/de9f8cdb7146021
-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer

[PATCH] mmtests: actually use variable SOCKETSIZE_OPT

From: Jesper Dangaard Brouer <brouer@redhat.com>

commit 7f16226577b2 ("netperf: Set remote and local socket max buffer
sizes") removed netperf's setting of the socket buffer sizes and
instead used global /proc/sys settings.

commit de9f8cdb7146 ("netperf: Only adjust socket sizes for
UDP_STREAM") re-added explicit netperf setting socket buffer sizes for
remote-host testing (saved in SOCKETSIZE_OPT). Only problem is this
variable is not used after commit 7f16226577b2.

Simply use $SOCKETSIZE_OPT when invoking netperf command.

Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
---
 shellpack_src/src/netperf/netperf-bench |    2 +-
 shellpacks/shellpack-bench-netperf      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/shellpack_src/src/netperf/netperf-bench b/shellpack_src/src/netperf/netperf-bench
index 8e7d02864c4a..b2820610936e 100755
--- a/shellpack_src/src/netperf/netperf-bench
+++ b/shellpack_src/src/netperf/netperf-bench
@@ -93,7 +93,7 @@ mmtests_server_ctl start --serverside-name $PROTOCOL-$SIZE
 		-t $PROTOCOL \
 		-i 3,3 -I 95,5 \
 		-H $SERVER_HOST \
-		-- $MSGSIZE_OPT $EXTRA \
+		-- $SOCKETSIZE_OPT $MSGSIZE_OPT $EXTRA \
 			2>&1 | tee $LOGDIR_RESULTS/$PROTOCOL-${SIZE}.$ITERATION \
 			|| die Failed to run netperf
 	monitor_post_hook $LOGDIR_RESULTS $SIZE
diff --git a/shellpacks/shellpack-bench-netperf b/shellpacks/shellpack-bench-netperf
index 2ce26ba39f1b..7356082d5a78 100755
--- a/shellpacks/shellpack-bench-netperf
+++ b/shellpacks/shellpack-bench-netperf
@@ -190,7 +190,7 @@ for ITERATION in `seq 1 $ITERATIONS`; do
 		-t $PROTOCOL \
 		-i 3,3 -I 95,5 \
 		-H $SERVER_HOST \
-		-- $MSGSIZE_OPT $EXTRA \
+		-- $SOCKETSIZE_OPT $MSGSIZE_OPT $EXTRA \
 			2>&1 | tee $LOGDIR_RESULTS/$PROTOCOL-${SIZE}.$ITERATION \
 			|| die Failed to run netperf
 	monitor_post_hook $LOGDIR_RESULTS $SIZE

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman <mgorman@techsingularity.net> - 2016-12-07 11:20 +0100
  Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Christoph Lameter <cl@linux.com> - 2016-12-07 16:00 +0100
    Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman <mgorman@techsingularity.net> - 2016-12-07 17:00 +0100
      Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Christoph Lameter <cl@linux.com> - 2016-12-07 17:50 +0100
        Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman <mgorman@techsingularity.net> - 2016-12-07 17:50 +0100
          Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Christoph Lameter <cl@linux.com> - 2016-12-07 18:20 +0100
            Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman <mgorman@techsingularity.net> - 2016-12-07 18:40 +0100
  Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Eric Dumazet <eric.dumazet@gmail.com> - 2016-12-07 20:10 +0100
    Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Eric Dumazet <eric.dumazet@gmail.com> - 2016-12-07 20:20 +0100
    Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman <mgorman@techsingularity.net> - 2016-12-07 20:50 +0100
      Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Eric Dumazet <eric.dumazet@gmail.com> - 2016-12-07 21:20 +0100
        Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman <mgorman@techsingularity.net> - 2016-12-07 22:30 +0100
          Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman <mgorman@techsingularity.net> - 2016-12-08 00:30 +0100
            Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Jesper Dangaard Brouer <brouer@redhat.com> - 2016-12-08 09:30 +0100
              Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman <mgorman@techsingularity.net> - 2016-12-08 10:20 +0100
                Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Jesper Dangaard Brouer <brouer@redhat.com> - 2016-12-08 11:50 +0100
                Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman <mgorman@techsingularity.net> - 2016-12-08 12:10 +0100
                Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Jesper Dangaard Brouer <brouer@redhat.com> - 2016-12-08 15:50 +0100
                Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman <mgorman@techsingularity.net> - 2016-12-08 16:20 +0100
                Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Jesper Dangaard Brouer <brouer@redhat.com> - 2016-12-08 18:30 +0100
                Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Mel Gorman <mgorman@techsingularity.net> - 2016-12-08 18:40 +0100
                Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v7 Eric Dumazet <eric.dumazet@gmail.com> - 2016-12-08 17:10 +0100

csiph-web