Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1538543

Re: [PATCH 0/5] staging-COMEDI: Fine-tuning for three functions

Show all headers | View raw

On Thu, Dec 08, 2016 at 12:30:20PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 8 Dec 2016 11:37:37 +0100
> 
> Some update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (5):
>   Combine four kcalloc() calls into one in serial2002_setup_subdevs()
>   Split a condition check in usbdux_alloc_usb_buffers()
>   Move an assignment in usbdux_alloc_usb_buffers()
>   Split a condition check in usbduxsigma_alloc_usb_buffers()
>   Move an assignment in usbduxsigma_alloc_usb_buffers()
> 
>  drivers/staging/comedi/drivers/serial2002.c  | 22 +++++-----
>  drivers/staging/comedi/drivers/usbdux.c      | 56 ++++++++++++++++++-----
>  drivers/staging/comedi/drivers/usbduxsigma.c | 66 ++++++++++++++++++++++------
>  3 files changed, 108 insertions(+), 36 deletions(-)

You do realize that I no longer take patches from you for any of the
subsystems I maintain, right?  This patch series is one reason why...

I suggest working on other projects to learn C better first.

best of luck,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] staging-COMEDI: Fine-tuning for three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-08 12:40 +0100
  [PATCH 2/5] staging: comedi: usbdux: Split a condition check in  usbdux_alloc_usb_buffers() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-08 12:40 +0100
    Re: [PATCH 2/5] staging: comedi: usbdux: Split a condition check in  usbdux_alloc_usb_buffers() Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-08 13:40 +0100
    Re: [PATCH 2/5] staging: comedi: usbdux: Split a condition check in  usbdux_alloc_usb_buffers() Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-08 13:50 +0100
    Re: [PATCH 2/5] staging: comedi: usbdux: Split a condition check in  usbdux_alloc_usb_buffers() Ian Abbott <abbotti@mev.co.uk> - 2016-12-08 13:50 +0100
      Re: staging: comedi: usbdux: Split a condition check in  usbdux_alloc_usb_buffers() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-08 16:50 +0100
  Re: [PATCH 0/5] staging-COMEDI: Fine-tuning for three functions Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-08 14:40 +0100
    Re: staging-COMEDI: Fine-tuning for three functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-12-08 16:30 +0100

csiph-web