Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1538414
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ASoC: Intel: Skylake: remove unused 'out_fmt' variable |
| Date | 2016-12-08 11:10 +0100 |
| Message-ID | <sM3Oh-4RM-21@gated-at.bofh.it> (permalink) |
| References | <sM041-2pi-7@gated-at.bofh.it> <sM3EB-4x2-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Dec 08, 2016 at 03:30:01PM +0530, Vinod Koul wrote: > On Wed, Dec 07, 2016 at 10:01:42PM -0800, Kirtika Ruchandani wrote: > > Commit 4cd9899f0d16 introduced struct skl_module_fmt* out_fmt without > > using it. Compiling with W=1 gives the below warning, fix it. > > > > sound/soc/intel/skylake/skl-topology.c: In function ‘skl_tplg_update_buffer_size’: > > sound/soc/intel/skylake/skl-topology.c:301:34: warning: variable ‘out_fmt’ set but not used [-Wunused-but-set-variable] > > > > This is a harmless warning and is only being fixed to reduce the noise > > with W=1 in the kernel. > > Heya, > > Can you please tell me which tree this warning was found on? At least this > doesn't exist upstream. The out_fmt is very well used. Sorry I messed up, got confused mcfg->out_fmt variable :( This looks fine: Acked-by: Vinod Koul <vinod.koul@intel.com> -- ~Vinod
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ASoC: Intel: Skylake: remove unused 'out_fmt' variable Kirtika Ruchandani <kirtika@chromium.org> - 2016-12-08 07:10 +0100
Re: [PATCH] ASoC: Intel: Skylake: remove unused 'out_fmt' variable Vinod Koul <vinod.koul@intel.com> - 2016-12-08 11:00 +0100
Re: [PATCH] ASoC: Intel: Skylake: remove unused 'out_fmt' variable Vinod Koul <vinod.koul@intel.com> - 2016-12-08 11:10 +0100
Re: [PATCH] ASoC: Intel: Skylake: remove unused 'out_fmt' variable Mark Brown <broonie@kernel.org> - 2016-12-08 17:20 +0100
csiph-web