Re: [PATCH 1/4] sched: move IO scheduling accounting from io_schedule_timeout() to __schedule()

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] sched: move IO scheduling accounting from io_schedule_timeout() to __schedule()
Date	2016-12-06 22:40 +0100
Message-ID	<sLvCW-7rL-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <sxk4L-3ru-25@gated-at.bofh.it> <sxkHn-3Tx-3@gated-at.bofh.it> <sxsvg-tH-7@gated-at.bofh.it> <sxsvg-tH-5@gated-at.bofh.it> <synWx-4Wn-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Mon, Oct 31, 2016 at 10:45:56AM -0600, Tejun Heo wrote:
> Tracking the owners of mutexes and rwsems does help quite a bit.  I
> don't think it's as simple as inheriting io sleep state from the
> current owner tho.  The owner might be running or in a non-IO sleep
> when others try to grab the mutex.  It is an option to ignore those
> cases but this would have a real possibility to lead to surprising
> results in some corner cases.  If we choose to propagate dynamically,
> it becomes an a lot more complex problem and I don't think it'd be
> justfiable.
> 
> Unless there can be a simple enough and reliable solution, I think
> it'd be better to stick with explicit marking.

Just posted the fixed version for the first patch.  Any more thoughts
on this?

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/4] sched: move IO scheduling accounting from  io_schedule_timeout() to __schedule() Tejun Heo <tj@kernel.org> - 2016-12-06 22:40 +0100

csiph-web