Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1537223

Re: Avoid deadlock situation due to use of xmit_lock

Show all headers | View raw

Hi,

On 06.12.2016 16:06, David Miller wrote:
> From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> Date: Sat,  3 Dec 2016 00:06:04 +0100
> 
>> after stumbling over a potential deadlock situation in the altera driver 
>> (see http://marc.info/?l=linux-netdev&m=148054615230447&w=2), I checked
>> all other ethernet drivers for the same issue and actually found it in 2
>> more, namely stmmac, and sxgbe. Please see the commit messages for a 
>> description of the problem.
>> These 2 patches fix the concerning drivers.
> 
> First of all, I don't want to apply these patches without proper testing
> and ACKs from the individual driver maintainers.
> 
> For both of these drivers, this situation only exists because the TX
> path uses the unnecessary ->tx_lock.  This private lock should be
> removed completely and the driver should use the lock the mid-layer
> already holds in the transmit path and take it in the TX reclaim path
> instead of the private ->tx_lock.
> 

Ok, I will prepare a new set of patches to remove those private locks entirely.

Regards,
Lino

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Avoid deadlock situation due to use of xmit_lock Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-12-03 00:10 +0100
  [PATCH 2/2] net: ethernet: stmmac: do not use xmit_lock in tx completion handler Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-12-03 00:10 +0100
  Re: Avoid deadlock situation due to use of xmit_lock David Miller <davem@davemloft.net> - 2016-12-06 16:10 +0100
    Re: Avoid deadlock situation due to use of xmit_lock Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-12-06 20:20 +0100

csiph-web