Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1537217

Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in spi_nor_write()

Show all headers | View raw

On 12/06/2016 06:14 PM, Cyrille Pitchen wrote:
> This patch removes the WARN_ONCE() test in spi_nor_write().
> This macro triggers the display of a warning message almost every time we
> use a UBI file-system because a write operation is performed at offset 64,
> which is in the middle of the SPI NOR memory page. This is a valid
> operation for ubifs.

Is that a valid operation for all spi nors ?

> Hence this warning is pretty annoying and useless so we just remove it.
> 
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
> Suggested-by: Richard Weinberger <richard@nod.at>
> Suggested-by: Andras Szemzo <szemzo.andras@gmail.com>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index c9bcd05ca5d9..cdeb2c6b1492 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1265,9 +1265,6 @@ static int spi_nor_write(struct mtd_info *mtd, loff_t to, size_t len,
>  		ssize_t written;
>  
>  		page_offset = (to + i) & (nor->page_size - 1);
> -		WARN_ONCE(page_offset,
> -			  "Writing at offset %zu into a NOR page. Writing partial pages may decrease reliability and increase wear of NOR flash.",
> -			  page_offset);
>  		/* the size of data remaining on the first page */
>  		page_remain = min_t(size_t,
>  				    nor->page_size - page_offset, len - i);
> 


-- 
Best regards,
Marek Vasut

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in spi_nor_write() Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-12-06 18:20 +0100
  Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in  spi_nor_write() Marek Vasut <marek.vasut@gmail.com> - 2016-12-06 20:10 +0100
    Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in  spi_nor_write() Marek Vasut <marek.vasut@gmail.com> - 2016-12-07 06:10 +0100
      RE: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in  spi_nor_write() "Krzeminski, Marcin (Nokia - PL/Wroclaw)"          <marcin.krzeminski@nokia.com> - 2016-12-07 07:40 +0100
        Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in  spi_nor_write() Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-12-07 14:10 +0100
          RE: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in  spi_nor_write() "Krzeminski, Marcin (Nokia - PL/Wroclaw)"          <marcin.krzeminski@nokia.com> - 2016-12-07 19:30 +0100
      Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in  spi_nor_write() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-12-07 08:50 +0100
    Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in  spi_nor_write() Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> - 2016-12-07 07:50 +0100
  Re: [PATCH 1/1] mtd: spi-nor: remove WARN_ONCE() message in  spi_nor_write() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-12-08 16:50 +0100

csiph-web