Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1537151
| From | Ray Jui <ray.jui@broadcom.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/5] ARM: BCM5301X: Specify USB controllers in DT |
| Date | 2016-12-06 18:30 +0100 |
| Message-ID | <sLrJ0-4ZP-21@gated-at.bofh.it> (permalink) |
| References | <sLrzj-4WB-25@gated-at.bofh.it> <sLrzj-4WB-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12/6/2016 9:17 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> There are 3 separated controllers, one per USB /standard/. With PHY
> drivers in place they can be simply supported with generic drivers.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> arch/arm/boot/dts/bcm5301x.dtsi | 33 ++++++++++++++++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index f09a2bb..bfc98d19 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -248,8 +248,26 @@
>
> #address-cells = <1>;
> #size-cells = <1>;
> + ranges;
>
> - phys = <&usb2_phy>;
> + interrupt-parent = <&gic>;
> +
> + ohci: ohci@21000 {
> + #usb-cells = <0>;
> +
> + compatible = "generic-ohci";
> + reg = <0x00022000 0x1000>;
Your label ohci@21000 does not match the 'reg' at 0x22000.
> + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + ehci: ehci@22000 {
> + #usb-cells = <0>;
> +
> + compatible = "generic-ehci";
> + reg = <0x00021000 0x1000>;
Looks like you got the label of ohci and ehci reversed?
> + interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> + phys = <&usb2_phy>;
> + };
> };
>
> usb3: usb3@23000 {
> @@ -257,6 +275,19 @@
>
> #address-cells = <1>;
> #size-cells = <1>;
> + ranges;
> +
> + interrupt-parent = <&gic>;
> +
> + xhci: xhci@23000 {
> + #usb-cells = <0>;
> +
> + compatible = "generic-xhci";
> + reg = <0x00023000 0x1000>;
> + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
> + phys = <&usb3_phy>;
> + phy-names = "usb";
> + };
> };
>
> spi@29000 {
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/5] ARM: BCM5301X: Specify USB controllers in DT Rafał Miłecki <zajec5@gmail.com> - 2016-12-06 18:20 +0100
Re: [PATCH 2/5] ARM: BCM5301X: Specify USB controllers in DT Ray Jui <ray.jui@broadcom.com> - 2016-12-06 18:30 +0100
Re: [PATCH 2/5] ARM: BCM5301X: Specify USB controllers in DT Rafał Miłecki <zajec5@gmail.com> - 2016-12-06 18:40 +0100
Re: [PATCH 2/5] ARM: BCM5301X: Specify USB controllers in DT Ray Jui <ray.jui@broadcom.com> - 2016-12-06 18:40 +0100
csiph-web