Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1537058

Re: [PATCH] uapi glibc compat: fix outer guard of net device flags enum

Show all headers | View raw

From: Mikko Rapeli <mikko.rapeli@iki.fi>
Date: Mon, 5 Dec 2016 19:34:02 +0200

> On Sat, Dec 03, 2016 at 05:31:45PM +0100, Jonas Gorski wrote:
>> Fix a wrong condition preventing the higher net device flags
>> IFF_LOWER_UP etc to be defined if net/if.h is included before
>> linux/if.h.
>> 
>> The comment makes it clear the intention was to allow partial
>> definition with either parts.
>> 
>> This fixes compilation of userspace programs trying to use
>> IFF_LOWER_UP, IFF_DORMANT or IFF_ECHO.
>> 
>> Fixes: 4a91cb61bb99 ("uapi glibc compat: fix compile errors when glibc net/if.h included before linux/if.h")
>> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> 
> Reviewed-by: Mikko Rapeli <mikko.rapeli@iki.fi>
> 
> Yep, sorry about the logic error. Thanks for the fix!

Applied.

Jonas, please properly put netdev@vger.kernel.org on the CC: for networking
patches in the future.

Thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] uapi glibc compat: fix outer guard of net device flags enum Jonas Gorski <jonas.gorski@gmail.com> - 2016-12-03 17:50 +0100
  Re: [PATCH] uapi glibc compat: fix outer guard of net device flags  enum Mikko Rapeli <mikko.rapeli@iki.fi> - 2016-12-05 18:40 +0100
    Re: [PATCH] uapi glibc compat: fix outer guard of net device flags  enum David Miller <davem@davemloft.net> - 2016-12-06 16:50 +0100

csiph-web