RE: [PATCH V2 03/13] perf/x86: output sampling overhead

From	"Liang, Kan" <kan.liang@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH V2 03/13] perf/x86: output sampling overhead
Date	2016-12-06 16:10 +0100
Message-ID	<sLpxw-3FC-19@gated-at.bofh.it> (permalink)
References	<sK3z3-Gp-3@gated-at.bofh.it> <sK3z3-Gp-1@gated-at.bofh.it> <sLm6B-1mB-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


> On Fri, Dec 02, 2016 at 04:19:11PM -0500, kan.liang@intel.com wrote:
> > From: Kan Liang <kan.liang@intel.com>
> >
> > On x86, NMI handler is the most important part which brings overhead
> > for sampling. Adding a pmu specific overhead type
> > PERF_PMU_SAMPLE_OVERHEAD for it.
> >
> > For other architectures which may don't have NMI, the overhead type
> > can be reused.
> >
> > Signed-off-by: Kan Liang <kan.liang@intel.com>
> > ---
> >  arch/x86/events/core.c          | 17 ++++++++++++++++-
> >  arch/x86/events/perf_event.h    |  2 ++
> >  include/uapi/linux/perf_event.h |  1 +
> >  3 files changed, 19 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c index
> > 9d4bf3a..de40f96 100644
> > --- a/arch/x86/events/core.c
> > +++ b/arch/x86/events/core.c
> > @@ -1397,6 +1397,9 @@ static void x86_pmu_del(struct perf_event
> > *event, int flags)
> >
> >  	perf_event_update_userpage(event);
> >
> > +	if ((flags & PERF_EF_LOG) && cpuc->nmi_overhead.nr)
> > +		perf_log_overhead(event, PERF_PMU_SAMPLE_OVERHEAD,
> > +&cpuc->nmi_overhead);
> > +
> >  do_del:
> >  	if (x86_pmu.del) {
> >  		/*
> 
> That's not at all mentioned in the changelog, and it clearly isn't
> nmi_overhead.

Here it only records the overhead, not calculate.
The calculation is in nmi_hanlder as below. I will make it clear in the changelog.

@@ -1492,8 +1505,10 @@ perf_event_nmi_handler(unsigned int cmd, struct pt_regs *regs)
 	start_clock = sched_clock();
 	ret = x86_pmu.handle_irq(regs);
 	finish_clock = sched_clock();
+	clock = finish_clock - start_clock;
 
-	perf_sample_event_took(finish_clock - start_clock);
+	perf_calculate_nmi_overhead(clock);
+	perf_sample_event_took(clock);
 
 	return ret;
 }

Thanks,
Kan

Thread

[PATCH V2 03/13] perf/x86: output sampling overhead kan.liang@intel.com - 2016-12-02 22:30 +0100
  Re: [PATCH V2 03/13] perf/x86: output sampling overhead Peter Zijlstra <peterz@infradead.org> - 2016-12-06 12:30 +0100
    RE: [PATCH V2 03/13] perf/x86: output sampling overhead "Liang, Kan" <kan.liang@intel.com> - 2016-12-06 16:10 +0100
      Re: [PATCH V2 03/13] perf/x86: output sampling overhead Peter Zijlstra <peterz@infradead.org> - 2016-12-06 16:40 +0100
        RE: [PATCH V2 03/13] perf/x86: output sampling overhead "Liang, Kan" <kan.liang@intel.com> - 2016-12-06 16:50 +0100
          Re: [PATCH V2 03/13] perf/x86: output sampling overhead Peter Zijlstra <peterz@infradead.org> - 2016-12-06 19:30 +0100
            RE: [PATCH V2 03/13] perf/x86: output sampling overhead "Liang, Kan" <kan.liang@intel.com> - 2016-12-07 20:10 +0100
  Re: [PATCH V2 03/13] perf/x86: output sampling overhead Peter Zijlstra <peterz@infradead.org> - 2016-12-06 13:10 +0100

csiph-web