Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

From	Andreas Gruenbacher <agruenba@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir
Date	2016-12-06 14:20 +0100
Message-ID	<sLnP4-2vS-33@gated-at.bofh.it> (permalink)
References	(5 earlier) <sL7hg-ed-23@gated-at.bofh.it> <sLaoN-2aw-15@gated-at.bofh.it> <sLaRP-2zb-3@gated-at.bofh.it> <sLaRP-2zb-1@gated-at.bofh.it> <sLkRb-E0-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 6, 2016 at 11:08 AM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> On Tue, Dec 6, 2016 at 12:24 AM, Andreas Grünbacher
> <andreas.gruenbacher@gmail.com> wrote:
>> 2016-12-06 0:19 GMT+01:00 Andreas Grünbacher <andreas.gruenbacher@gmail.com>:
>
>>> It's not hard to come up with a heuristic that determines if a
>>> system.nfs4_acl value is equivalent to a file mode, and to ignore the
>>> attribute in that case. (The file mode is transmitted in its own
>>> attribute already, so actually converting .) That way, overlayfs could
>>> still fail copying up files that have an actual ACL. It's still an
>>> ugly hack ...
>>
>> Actually, that kind of heuristic would make sense in the NFS client
>> which could then hide the "system.nfs4_acl" attribute.
>
> Even simpler would be if knfsd didn't send the attribute if not
> necessary.  Looks like there's code actively creating the nfs4_acl on
> the wire even if the filesystem had none:
>
>     pacl = get_acl(inode, ACL_TYPE_ACCESS);
>     if (!pacl)
>         pacl = posix_acl_from_mode(inode->i_mode, GFP_KERNEL);
>
> What's the point?

That's how the protocol is specified. (I'm not saying that that's very helpful.)

Andreas

Thread

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir Miklos Szeredi <miklos@szeredi.hu> - 2016-12-05 10:30 +0100
  Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir "J. Bruce Fields" <bfields@fieldses.org> - 2016-12-05 16:30 +0100
    Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir Miklos Szeredi <miklos@szeredi.hu> - 2016-12-05 16:40 +0100
      Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir "J. Bruce Fields" <bfields@fieldses.org> - 2016-12-05 17:30 +0100
        Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir Patrick Plagwitz <Patrick_Plagwitz@web.de> - 2016-12-05 19:30 +0100
        Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir Andreas Grünbacher <andreas.gruenbacher@gmail.com> - 2016-12-05 20:40 +0100
          Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir Patrick Plagwitz <Patrick_Plagwitz@web.de> - 2016-12-06 00:00 +0100
            Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir Andreas Grünbacher <andreas.gruenbacher@gmail.com> - 2016-12-06 00:30 +0100
              Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir Miklos Szeredi <miklos@szeredi.hu> - 2016-12-06 11:10 +0100
                Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir Andreas Gruenbacher <agruenba@redhat.com> - 2016-12-06 14:20 +0100
                Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir "J. Bruce Fields" <bfields@fieldses.org> - 2016-12-06 20:00 +0100
            Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir Andreas Grünbacher <andreas.gruenbacher@gmail.com> - 2016-12-06 00:30 +0100

csiph-web