Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1536786

Re: [PATCH v2] Staging: dgnc: dgnc_*.c: Use usleep_range over udelay to improve coalescing processor wakeups

Show all headers | View raw

On Tue, Dec 06, 2016 at 09:59:58AM +0100, Shiva Kerdel wrote:
> In most cases, usleep_range is better than udelay, as the precise wakeup
> from udelay is unnecessary.

But, udelay does something different than usleep, are you sure you
should be giving up the cpu at this point in time?

Are you sure you are even in a function that is allowed to sleep?  I
don't think that is the case for all of these at all, sorry, unless you
have the hardware to test this change, I can't take it.

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] Staging: dgnc: dgnc_*.c: Use usleep_range over udelay  to improve coalescing processor wakeups Greg KH <gregkh@linuxfoundation.org> - 2016-12-06 10:20 +0100
  Re: [PATCH v2] Staging: dgnc: dgnc_*.c: Use usleep_range over udelay  to improve coalescing processor wakeups Shiva Kerdel <shiva@exdev.nl> - 2016-12-06 11:10 +0100

csiph-web