Re: [PATCHv4 05/10] arm64: Use __pa_symbol for kernel symbols

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv4 05/10] arm64: Use __pa_symbol for kernel symbols
Date	2016-12-06 02:00 +0100
Message-ID	<sLcgW-3kv-17@gated-at.bofh.it> (permalink)
References	<sIVNf-3Mq-3@gated-at.bofh.it> <sIVNf-3Mq-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/29/2016 10:55 AM, Laura Abbott wrote:
> __pa_symbol is technically the marco that should be used for kernel
> symbols. Switch to this as a pre-requisite for DEBUG_VIRTUAL which
> will do bounds checking. As part of this, introduce lm_alias, a
> macro which wraps the __va(__pa(...)) idiom used a few places to
> get the alias.
> 
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> v4: Stop calling __va early, conversion of a few more sites. I decided against
> wrapping the __p*d_populate calls into new functions since the call sites
> should be limited.
> ---


> -	pud_populate(&init_mm, pud, bm_pmd);
> +	if (pud_none(*pud))
> +		__pud_populate(pud, __pa_symbol(bm_pmd), PMD_TYPE_TABLE);
>  	pmd = fixmap_pmd(addr);
> -	pmd_populate_kernel(&init_mm, pmd, bm_pte);
> +	__pmd_populate(pmd, __pa_symbol(bm_pte), PMD_TYPE_TABLE);

Is there a particular reason why pmd_populate_kernel() is not changed to
use __pa_symbol() instead of using __pa()? The other users in the arm64
kernel is arch/arm64/kernel/hibernate.c which seems to call this against
kernel symbols as well?
-- 
Florian

Thread

[PATCHv4 05/10] arm64: Use __pa_symbol for kernel symbols Laura Abbott <labbott@redhat.com> - 2016-11-29 20:00 +0100
  Re: [PATCHv4 05/10] arm64: Use __pa_symbol for kernel symbols Catalin Marinas <catalin.marinas@arm.com> - 2016-11-30 18:20 +0100
  Re: [PATCHv4 05/10] arm64: Use __pa_symbol for kernel symbols James Morse <james.morse@arm.com> - 2016-12-01 13:10 +0100
    Re: [PATCHv4 05/10] arm64: Use __pa_symbol for kernel symbols Mark Rutland <mark.rutland@arm.com> - 2016-12-06 17:10 +0100
  Re: [PATCHv4 05/10] arm64: Use __pa_symbol for kernel symbols Florian Fainelli <f.fainelli@gmail.com> - 2016-12-06 02:00 +0100
    Re: [PATCHv4 05/10] arm64: Use __pa_symbol for kernel symbols Catalin Marinas <catalin.marinas@arm.com> - 2016-12-06 12:50 +0100
  Re: [PATCHv4 05/10] arm64: Use __pa_symbol for kernel symbols Mark Rutland <mark.rutland@arm.com> - 2016-12-06 18:10 +0100
    Re: [PATCHv4 05/10] arm64: Use __pa_symbol for kernel symbols Laura Abbott <labbott@redhat.com> - 2016-12-06 20:20 +0100

csiph-web