Re: [PATCH] block: fix unintended fallthrough in generic_make_request_checks()

From	Nicolai Stange <nicstange@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] block: fix unintended fallthrough in generic_make_request_checks()
Date	2016-12-06 01:10 +0100
Message-ID	<sLbux-310-9@gated-at.bofh.it> (permalink)
References	<sKFuF-7V2-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Nicolai Stange <nicstange@gmail.com> writes:

> ---
> Applicable to next-20161202.
>
> Note that after this patch, I'm seeing a single
>  EXT4-fs (dm-1): Delayed block allocation failed for inode 2625094 at
>                  logical offset 2032 with max blocks 2 with error 121
> with 121 == EREMOTEIO
>
> This is because my SATA sda reports 0x20 (invalid command) back
> in response to 0x41 (WRITE_SAME).
>
> After this has happened, sd_done() disables "write same" once and for
> all, hence only this single message.
>
> I expect this to get fixed by
>   https://patchwork.kernel.org/patch/9321963/

Just FYI: Not really, the (supposedly) corresponding commit has already
been in linux-next when I was testing: commit 0ce1b18c42a5 ("libata:
Some drives failing on SCT Write Same").

I sent separate patch for this issue:
http://lkml.kernel.org/r/20161205235638.11539-1-nicstange@gmail.com

Regards,

Nicolai

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] block: fix unintended fallthrough in generic_make_request_checks() Nicolai Stange <nicstange@gmail.com> - 2016-12-04 15:00 +0100
  Re: [PATCH] block: fix unintended fallthrough in  generic_make_request_checks() Christoph Hellwig <hch@infradead.org> - 2016-12-05 13:40 +0100
  Re: [PATCH] block: fix unintended fallthrough in  generic_make_request_checks() Jens Axboe <axboe@kernel.dk> - 2016-12-05 16:00 +0100
  Re: [PATCH] block: fix unintended fallthrough in generic_make_request_checks() Nicolai Stange <nicstange@gmail.com> - 2016-12-06 01:10 +0100

csiph-web