Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1536535

Re: [PATCH v2] perf sched timehist: Improve error message when analyzing wrong file

Show all headers | View raw

On 11/29/16 9:31 PM, Namhyung Kim wrote:
> On 11/30/16, David Ahern <dsahern@gmail.com> wrote:
>> Arnaldo reported an unhelpful error message when running perf sched
>> timehist on a file that did not contain sched tracepoints:
>>
>>     [root@jouet ~]# perf sched timehist
>>     No trace sample to read. Did you call 'perf record -R'?
>>
>>     [root@jouet ~]# perf evlist -v
>>     cycles:ppp: size: 112, { sample_period, sample_freq }: 4000,
>> sample_type: IP|TID|TIME|CALLCHAIN|CPU|PERIOD, disabled: 1, inherit: 1,
>> mmap: 1, comm: 1, freq: 1, task: 1, precise_ip: 3, sample_id_all: 1,
>> exclude_guest: 1, mmap2: 1, comm_exec: 1
>>
>> Change the has_traces check to look for the sched_switch event. Analysis
>> for perf sched timehist requires at least this event.
>>
>> Now when analyzing a file without sched tracepoints you get:
>>
>>     root@f21-vbox:/tmp$ perf sched timehist
>>     No sched_switch events found. Have you run 'perf sched record'?
>>
>> Signed-off-by: David Ahern <dsahern@gmail.com>
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>
> 
> Thanks,
> Namhyung
> 

Arnaldo: I think this one has been overlooked

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] perf sched timehist: Improve error message when analyzing wrong file David Ahern <dsahern@gmail.com> - 2016-11-29 21:50 +0100
  Re: [PATCH v2] perf sched timehist: Improve error message when  analyzing wrong file Namhyung Kim <namhyung@kernel.org> - 2016-11-30 06:40 +0100
    Re: [PATCH v2] perf sched timehist: Improve error message when  analyzing wrong file David Ahern <dsahern@gmail.com> - 2016-12-06 00:50 +0100
      Re: [PATCH v2] perf sched timehist: Improve error message when  analyzing wrong file Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-06 17:20 +0100
  [tip:perf/core] perf sched timehist: Improve error message when  analyzing wrong file tip-bot for David Ahern <tipbot@zytor.com> - 2016-12-07 19:30 +0100

csiph-web