Re: [PATCH 1/2] Add DT bindings documentation for Synopsys UDC driver

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] Add DT bindings documentation for Synopsys UDC driver
Date	2016-12-06 00:10 +0100
Message-ID	<sLayt-2sU-9@gated-at.bofh.it> (permalink)
References	<sJ6fD-2kZ-1@gated-at.bofh.it> <sJ6fE-2kZ-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 30, 2016 at 11:35:09AM +0530, Raviteja Garimella wrote:
> This patch adds documentation for Synopsis Designware Cores AHB
> Subsystem Device Controller (UDC).
> 
> Signed-off-by: Raviteja Garimella <raviteja.garimella@broadcom.com>
> ---
>  .../devicetree/bindings/usb/snps,dw-ahb-udc.txt    | 29 ++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt b/Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt
> new file mode 100644
> index 0000000..64e1fbf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/snps,dw-ahb-udc.txt
> @@ -0,0 +1,29 @@
> +Synopsys USB Device controller.
> +
> +The device node is used for Synopsys Designware Cores AHB
> +Subsystem Device Controller (UDC).
> +
> +Required properties:
> + - compatible: should be "snps,dw-ahbudc"

Needs an SoC specific compatible string.

> + - reg: Offset and length of UDC register set
> + - interrupts: description of interrupt line
> + - phys: phandle to phy node.
> + - phy-names: name of phy node. Must be usb2drd.

A name is pointless when there's only 1 phy. Is this a device or dual 
role device(DRD)?

> + - extcon: phandle to the extcon device

I don't think extcon should be required. If this is UDC only, I'm not 
sure why you'd need it.

> +
> +Example:
> +
> +	usbdrd_phy: phy@6501c000 {
> +		#phy-cells = <0>;
> +		compatible = "brcm,ns2-drd-phy";
> +		reg = <0x66000000 0x1000>,
> +	}
> +
> +	udc_dwc: usb@664e0000 {
> +		compatible = "snps,dw-ahb-udc";

Doesn't match above.

> +		reg = <0x664e0000 0x2000>;
> +		interrupts = <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>;
> +		phys = <&usbdrd_phy>;
> +		phy-names = "usb2drd";
> +		extcon = <&usbdrd_phy>";

You are already describing the phy connection, you shouldn't need both.

> +	};
> -- 
> 2.1.0
>

Thread

[PATCH 0/2] Support for Synopsys UDC for ARM platforms  Raviteja Garimella <raviteja.garimella@broadcom.com> - 2016-11-30 07:10 +0100
  [PATCH 1/2] Add DT bindings documentation for Synopsys UDC driver Raviteja Garimella <raviteja.garimella@broadcom.com> - 2016-11-30 07:10 +0100
    Re: [PATCH 1/2] Add DT bindings documentation for Synopsys UDC driver Rob Herring <robh@kernel.org> - 2016-12-06 00:10 +0100
      Re: [PATCH 1/2] Add DT bindings documentation for Synopsys UDC driver Raviteja Garimella <raviteja.garimella@broadcom.com> - 2016-12-06 12:00 +0100
  Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver Felipe Balbi <balbi@kernel.org> - 2016-11-30 11:50 +0100
    Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver Raviteja Garimella <raviteja.garimella@broadcom.com> - 2016-11-30 13:50 +0100
      Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver Felipe Balbi <balbi@kernel.org> - 2016-11-30 13:50 +0100
        Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver John Youn <John.Youn@synopsys.com> - 2016-12-01 02:00 +0100
          Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver Felipe Balbi <balbi@kernel.org> - 2016-12-01 10:00 +0100

csiph-web