Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1538293

Re: [RFC 06/10] block: use tida as small id allocator

Show all headers | View raw

On 12/07/2016 06:23 PM, Rasmus Villemoes wrote:
> A struct ida ends up costing > 16 KB of runtime memory, which is quite
> a lot for something which on my laptop as of this writing has handed
> out 27 ids in its lifetime. So use the simpler and lighter-weight
> struct tida.

I'm worried that your example of your laptop isn't an all encompassing
test case. How well does the simplified ida allocator work for tens of
thousands of disks, at scan time? SCSI is notorious for setting up and
tearing down a ton of queues at probe time.

Unless we have more testing than 'it works on my laptop and saves 16k',
I'm not super intereted in the patch.


-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 00/10] implement alternative and much simpler id allocator Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-12-08 02:40 +0100
  [RFC 01/10] lib/idr.c: reused free bitmaps are already clear Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-12-08 02:40 +0100
  [RFC 02/10] lib/idr.c: delete useless condition Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-12-08 02:40 +0100
  [RFC 09/10] drm: use simpler id allocator Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-12-08 02:40 +0100
  [RFC 06/10] block: use tida as small id allocator Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-12-08 02:40 +0100
    Re: [RFC 06/10] block: use tida as small id allocator Jens Axboe <axboe@kernel.dk> - 2016-12-08 05:00 +0100
      Re: [RFC 06/10] block: use tida as small id allocator Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-08 12:20 +0100
  Re: [RFC 00/10] implement alternative and much simpler id allocator Tejun Heo <tj@kernel.org> - 2016-12-09 14:50 +0100
  Re: [RFC 00/10] implement alternative and much simpler id allocator Andrew Morton <akpm@linux-foundation.org> - 2016-12-09 23:10 +0100

csiph-web