Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

From	John Youn <John.Youn@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode
Date	2016-12-08 04:10 +0100
Message-ID	<sLXfP-t3-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <sIOiJ-7oC-23@gated-at.bofh.it> <sIPeO-7XO-23@gated-at.bofh.it> <sIPHP-8re-11@gated-at.bofh.it> <sLJmx-8sl-3@gated-at.bofh.it> <sLJPz-a6-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/7/2016 4:44 AM, Felipe Balbi wrote:
> 
> Hi,
> 
> Roger Quadros <rogerq@ti.com> writes:
>>>> Roger Quadros <rogerq@ti.com> writes:
>>>>> DCFG.DEVSPD == 0x3 is not valid and we need to set
>>>>> DCFG.DEVSPD to 0x1 for full speed mode.
>>>>
>>>> seems like it has been made invalid somewhere between 1.73a and
>>>> 2.60a. Can you figure it out from Documentation why and when it was made
>>>> invalid? We might need revision checks here.
>>>>
>>>
>>> I'll try to dig out more.
>>
>> I couldn't figure out more information on this. The changelogs in the TRMs
>> don't capture this change and I don't have access to all TRM versions
>> so I can't say which version it got changed and why.
>>
>> Can we please involve someone from Synopsis to provide this information?
>> Thanks.
> 
> John, could you help us with this query? We'd like to understand why one
> of the FULLSPEED modes got removed. Do we need a revision check or can
> we assume that the other mode was never supposed to be used?
> 

Full speed is 0x1. 0x3 may still work due to how the bits are
checked. But it definitely should be 0x1.

I'm not sure if it was 0x3 before. I still need to confirm whether
that was the case or not and if so why.

Regards,
John

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] usb: dwc3: gadget: Fix full speed mode Roger Quadros <rogerq@ti.com> - 2016-11-29 12:00 +0100
  Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode Felipe Balbi <balbi@kernel.org> - 2016-11-29 13:00 +0100
    Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode Roger Quadros <rogerq@ti.com> - 2016-11-29 13:30 +0100
      Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode Roger Quadros <rogerq@ti.com> - 2016-12-07 13:20 +0100
        Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode Felipe Balbi <balbi@kernel.org> - 2016-12-07 13:50 +0100
          Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode John Youn <John.Youn@synopsys.com> - 2016-12-08 04:10 +0100

csiph-web