Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1538200
| From | James Simmons <jsimmons@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/8] staging/lustre/ldlm: Correct itree_overlap_cb return type |
| Date | 2016-12-08 01:20 +0100 |
| Message-ID | <sLUBj-7gp-11@gated-at.bofh.it> (permalink) |
| References | <sLTcd-6aD-3@gated-at.bofh.it> <sLTcd-6aD-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> As per interval_search() prototype, the callback should return
> enum, not int.
> This fixes correspondign sparse warning.
>
> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Reviewed-by: James Simmons <jsimmons@infradead.org>
> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> index a4a291a..f4cbc89 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> @@ -1148,7 +1148,7 @@ static int lock_matches(struct ldlm_lock *lock, struct lock_match_data *data)
> return INTERVAL_ITER_STOP;
> }
>
> -static unsigned int itree_overlap_cb(struct interval_node *in, void *args)
> +static enum interval_iter itree_overlap_cb(struct interval_node *in, void *args)
> {
> struct ldlm_interval *node = to_ldlm_interval(in);
> struct lock_match_data *data = args;
> --
> 2.7.4
>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/8] Sparse warning fixes in Lustre. Oleg Drokin <green@linuxhacker.ru> - 2016-12-07 23:50 +0100
[PATCH 4/8] staging/lustre/lov: make lov_lsm_alloc() static Oleg Drokin <green@linuxhacker.ru> - 2016-12-07 23:50 +0100
[PATCH 7/8] staging/lustre: Move lov_read_and_clear_async_rc declaration Oleg Drokin <green@linuxhacker.ru> - 2016-12-07 23:50 +0100
Re: [PATCH 7/8] staging/lustre: Move lov_read_and_clear_async_rc declaration James Simmons <jsimmons@infradead.org> - 2016-12-08 01:30 +0100
[PATCH 2/8] staging/lustre/ldlm: Correct itree_overlap_cb return type Oleg Drokin <green@linuxhacker.ru> - 2016-12-07 23:50 +0100
Re: [PATCH 2/8] staging/lustre/ldlm: Correct itree_overlap_cb return type James Simmons <jsimmons@infradead.org> - 2016-12-08 01:20 +0100
Re: [PATCH 2/8] staging/lustre/ldlm: Correct itree_overlap_cb return type James Simmons <jsimmons@infradead.org> - 2016-12-08 01:30 +0100
[PATCH 1/8] staging/lustre/llite: move root_squash from sysfs to debugfs Oleg Drokin <green@linuxhacker.ru> - 2016-12-07 23:50 +0100
Re: [PATCH 1/8] staging/lustre/llite: move root_squash from sysfs to debugfs James Simmons <jsimmons@infradead.org> - 2016-12-08 01:50 +0100
[PATCH 8/8] staging/lustre/ptlrpc: Move nrs_conf_fifo extern to a header Oleg Drokin <green@linuxhacker.ru> - 2016-12-07 23:50 +0100
Re: [PATCH 0/8] Sparse warning fixes in Lustre. Al Viro <viro@ZenIV.linux.org.uk> - 2016-12-08 00:50 +0100
csiph-web