Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1538145

Re: [PATCH] nvme: use the correct msix vector for each queue

From Dan Streetman <ddstreet@ieee.org>
Newsgroups linux.kernel
Subject Re: [PATCH] nvme: use the correct msix vector for each queue
Date 2016-12-08 00:00 +0100
Message-ID <sLTlU-6gc-9@gated-at.bofh.it> (permalink)
References <sLSzw-5Ru-9@gated-at.bofh.it> <sLT2x-63V-11@gated-at.bofh.it> <sLT2x-63V-13@gated-at.bofh.it> <sLT2x-63V-9@gated-at.bofh.it> <sLTcd-6aD-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Dec 7, 2016 at 5:46 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Dec 07, 2016 at 05:49:42PM -0500, Keith Busch wrote:
>> I'm just saying that blk-mq's hctx mapping will end up choosing a queue
>> who's vector is mapped to a different CPU, and we don't want that.
>
> Right.  For 4.10 we could use the pci_alloc_irq_vectors_affinity helper
> to set away a pre_vector IFF we want a separate vector for the admin
> queue.
>
>> We are currently sharing the first IO queue's interrupt vector with
>> the admin queue's on purpose. Are you saying there's something wrong
>> with that?
>
> But given that the sharing was done intentionally and we had a long
> discussion on it back then there should be no real reason to change
> the assignment in NVMe.

sorry, i missed the past discussion.  It still seems strange and
obscure that it's intentional, from reading the code at least.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] nvme: use the correct msix vector for each queue Dan Streetman <ddstreet@ieee.org> - 2016-12-07 23:10 +0100
  Re: [PATCH] nvme: use the correct msix vector for each queue Keith Busch <keith.busch@intel.com> - 2016-12-07 23:40 +0100
    Re: [PATCH] nvme: use the correct msix vector for each queue Christoph Hellwig <hch@infradead.org> - 2016-12-07 23:50 +0100
      Re: [PATCH] nvme: use the correct msix vector for each queue Dan Streetman <ddstreet@ieee.org> - 2016-12-08 00:00 +0100
    Re: [PATCH] nvme: use the correct msix vector for each queue Dan Streetman <ddstreet@ieee.org> - 2016-12-07 23:50 +0100
      Re: [PATCH] nvme: use the correct msix vector for each queue Keith Busch <keith.busch@intel.com> - 2016-12-08 00:00 +0100
  Re: [PATCH] nvme: use the correct msix vector for each queue Keith Busch <keith.busch@intel.com> - 2016-12-07 23:40 +0100
    Re: [PATCH] nvme: use the correct msix vector for each queue Dan Streetman <ddstreet@ieee.org> - 2016-12-07 23:40 +0100

csiph-web