Re: [PATCH v8 8/8] cpufreq: intel_pstate: Use CPPC to get max performance

From	Tim Chen <tim.c.chen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 8/8] cpufreq: intel_pstate: Use CPPC to get max performance
Date	2016-12-08 00:20 +0100
Message-ID	<sLTFf-6FW-21@gated-at.bofh.it> (permalink)
References	<sGpRv-3CL-5@gated-at.bofh.it> <sGpRv-3CL-17@gated-at.bofh.it> <sLPLj-46c-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2016-12-07 at 20:06 +0100, Sebastian Andrzej Siewior wrote:
> 
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  drivers/acpi/cppc_acpi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index d0d0504b7c89..93252e5374c5 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -803,6 +803,7 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)
>  		if (addr)
>  			iounmap(addr);
>  	}
> +	per_cpu(cpc_desc_ptr, pr->id) = NULL;
>  	kfree(cpc_ptr);
>  
>  out_buf_free:
> @@ -824,6 +825,8 @@ void acpi_cppc_processor_exit(struct acpi_processor *pr)
>  	void __iomem *addr;
>  
>  	cpc_ptr = per_cpu(cpc_desc_ptr, pr->id);
> +	if (!cpc_ptr)
> +		return;

I agree that not handling null pointer here is a bug that should be fixed.
The cpc_ptr is checked at other places like acpi_get_psd_map.  
We could potentially have a null cpc_ptr say when
the parsing of CPC table failed. We should handle such cases gracefully.

Tim

Thread

Re: [PATCH v8 8/8] cpufreq: intel_pstate: Use CPPC to get max  performance Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-12-07 20:10 +0100
  Re: [PATCH v8 8/8] cpufreq: intel_pstate: Use CPPC to get max  performance Tim Chen <tim.c.chen@linux.intel.com> - 2016-12-08 00:20 +0100
    Re: [PATCH v8 8/8] cpufreq: intel_pstate: Use CPPC to get max performance "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-12-08 00:40 +0100
      Re: [PATCH v8 8/8] cpufreq: intel_pstate: Use CPPC to get max  performance Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-12-09 15:50 +0100
        Re: [PATCH v8 8/8] cpufreq: intel_pstate: Use CPPC to get max performance "Rafael J. Wysocki" <rafael@kernel.org> - 2016-12-09 16:10 +0100
          [PATCH] ACPI / CPPC: Fix per-CPU pointers management "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-12-10 01:00 +0100
            Re: [PATCH] ACPI / CPPC: Fix per-CPU pointers management Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-12-10 20:00 +0100

csiph-web