Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1538075

Re: [PATCH] ARM: dts: imx7d: fix LCDIF clock assignment

Show all headers | View raw

On Mon, Dec 05, 2016 at 10:01:24AM +0800, Shawn Guo wrote:
> Hi Arnd, Olof,
> 
> On Sun, Dec 04, 2016 at 05:26:58PM -0800, Stefan Agner wrote:
> > Hi Shawn
> > 
> > On 2016-11-23 15:02, Fabio Estevam wrote:
> > > On Tue, Nov 22, 2016 at 10:42 PM, Stefan Agner <stefan@agner.ch> wrote:
> > >> The eLCDIF IP of the i.MX 7 SoC knows multiple clocks and lists them
> > >> separately:
> > >>
> > >> Clock      Clock Root              Description
> > >> apb_clk    MAIN_AXI_CLK_ROOT       AXI clock
> > >> pix_clk    LCDIF_PIXEL_CLK_ROOT    Pixel clock
> > >> ipg_clk_s  MAIN_AXI_CLK_ROOT       Peripheral access clock
> > >>
> > >> All of them are switched by a single gate, which is part of the
> > >> IMX7D_LCDIF_PIXEL_ROOT_CLK clock. Hence using that clock also for
> > >> the AXI bus clock (clock-name "axi") makes sure the gate gets
> > >> enabled when accessing registers.
> > >>
> > >> There seem to be no separate AXI display clock, and the clock is
> > >> optional. Hence remove the dummy clock.
> > >>
> > >> This fixes kernel freezes when starting the X-Server (which
> > >> disables/re-enables the display controller).
> > >>
> > >> Signed-off-by: Stefan Agner <stefan@agner.ch>
> > > 
> > > Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> > 
> > Since this fixes a kernel freeze, is there a chance to get this still in
> > 4.9?
> 
> Since we get one more week to the final 4.9, is it possible for you to
> send this fix for 4.9 inclusion?  Thanks.
> 
> For the patch,
> 
> Acked-by: Shawn Guo <shawnguo@kernel.org>

Applied, with the fixes line. In the future, please email arm@kernel.org too,
it's easier to make sure we don't miss it that way.


-Olof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ARM: dts: imx7d: fix LCDIF clock assignment Stefan Agner <stefan@agner.ch> - 2016-12-05 02:40 +0100
  Re: [PATCH] ARM: dts: imx7d: fix LCDIF clock assignment Shawn Guo <shawnguo@kernel.org> - 2016-12-05 03:10 +0100
    Re: [PATCH] ARM: dts: imx7d: fix LCDIF clock assignment Olof Johansson <olof@lixom.net> - 2016-12-07 22:00 +0100
      Re: [PATCH] ARM: dts: imx7d: fix LCDIF clock assignment Shawn Guo <shawnguo@kernel.org> - 2016-12-08 02:00 +0100
  Re: [PATCH] ARM: dts: imx7d: fix LCDIF clock assignment Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-12-05 08:10 +0100
    Re: [PATCH] ARM: dts: imx7d: fix LCDIF clock assignment Stefan Agner <stefan@agner.ch> - 2016-12-05 21:40 +0100

csiph-web