Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

From	Santosh Shilimkar <santosh.shilimkar@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info
Date	2016-12-07 21:50 +0100
Message-ID	<sLRk5-4Vw-3@gated-at.bofh.it> (permalink)
References	<sLNzQ-2yE-29@gated-at.bofh.it> <sLNTb-2UC-19@gated-at.bofh.it> <sLOcy-31p-19@gated-at.bofh.it> <sLOme-34v-13@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

On 12/7/2016 9:36 AM, David Miller wrote:

[...]

> What does the newer tool do on an older kernel if it doesn't see
> the fields?  Does it check the size of the structure given back
> to it, and conditionally handle the older vs. the newer layout?
>
> It must do this.
>
Right but the rds-tool doesn't handle it well and needs
to be fixed before this or any additional change in rds-info
structures. To handle the kernel struct size issues with its
user copy, there is a provision to probe kernel struct len
and then decide on layout buts its not used/implemented
in tools. The parsing comment I made is also not completely
accurate.

For now, I will drop this patch and submit it once the tools
code is fixed along with other used fields to handle both
layouts.

I should have checked the full compatibility matrix as you
commented. Sorry for oversight. Thanks for your comments Dave.

Regard,
Santosh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 05:10 +0100
  Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection  cache usage info David Miller <davem@davemloft.net> - 2016-12-07 17:00 +0100
    Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache  usage info Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 17:50 +0100
      Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection  cache usage info David Miller <davem@davemloft.net> - 2016-12-07 18:10 +0100
        Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache  usage info Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 18:30 +0100
          Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection  cache usage info David Miller <davem@davemloft.net> - 2016-12-07 18:40 +0100
            Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache  usage info Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 21:50 +0100

csiph-web