Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1538026

Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin

Show all headers | View raw

Am Mittwoch, 7. Dezember 2016, 09:41:39 CET schrieb Brian Norris:
> On Wed, Dec 07, 2016 at 06:12:13PM +0100, Heiko Stuebner wrote:
> > Hi Brian,
> > 
> > Am Donnerstag, 1. Dezember 2016, 18:27:30 CET schrieb Brian Norris:
> > > Gru is a base dev board for a family of devices, including Kevin. Both
> > > utilize Rockchip RK3399, and they share much of their design.
> > > 
> > > Signed-off-by: Brian Norris <briannorris@chromium.org>
> > > ---
> > > 
> > >  Documentation/devicetree/bindings/arm/rockchip.txt | 20
> > > 
> > > ++++++++++++++++++++ 1 file changed, 20 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
> > > b/Documentation/devicetree/bindings/arm/rockchip.txt index
> > > cc4ace6397ab..830e13f5890c 100644
> > > --- a/Documentation/devicetree/bindings/arm/rockchip.txt
> > > +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
> > > @@ -99,6 +99,26 @@ Rockchip platforms device tree bindings
> > > 
> > >  		     "google,veyron-speedy-rev3", "google,veyron-speedy-rev2",
> > >  		     "google,veyron-speedy", "google,veyron", "rockchip,rk3288";
> > > 
> > > +- Google Gru (dev-board):
> > boards sorted alphabetically please
> > 
> > Brian, Gru, Jaq, ... Kevin, ...
> > 
> > While the sorting of old boards is not right yet, new boards should be
> > sorted.
> I got the idea that there was some attempt to group logically before
> alphabetically. Like keeping board/SoC families together. But maybe not.
> 
> I can do as you suggested, if you don't care about keeping actual
> similar boards together (i.e., veyron/3288 vs gru/3399).

I'd prefer a simple alphabetical sorting.

I think people reading the document will know what device they have, but not 
necessarily the actual soc in it. At least I would look for Google Kevin 
primarily without thinking of the soc at first.

And in general, most Rockchip boards (maybe except Google-boards) tend to 
follow the reference design quite closely, so it may become hard to decide 
when one is similar to another :-) . So best to keep it simple.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin Brian Norris <briannorris@chromium.org> - 2016-12-02 03:40 +0100
  Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin Heiko Stuebner <heiko@sntech.de> - 2016-12-07 18:20 +0100
    Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin Brian Norris <briannorris@chromium.org> - 2016-12-07 18:50 +0100
      Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin Heiko Stuebner <heiko@sntech.de> - 2016-12-07 20:20 +0100
  Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin Rob Herring <robh@kernel.org> - 2016-12-09 19:00 +0100
    Re: [PATCH 6/9] dt-bindings: Document rk3399 Gru/Kevin Heiko Stuebner <heiko@sntech.de> - 2016-12-09 19:30 +0100

csiph-web