Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1538001
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v4 1/5] i2c: designware: Refactoring of the i2c-designware |
| Date | 2016-12-07 20:00 +0100 |
| Message-ID | <sLPBE-3ND-35@gated-at.bofh.it> (permalink) |
| References | <sLOFz-3bg-3@gated-at.bofh.it> <sLOFA-3bg-11@gated-at.bofh.it> |
| Organization | Intel Finland Oy |
On Wed, 2016-12-07 at 17:55 +0000, Luis Oliveira wrote:
> - Factor out all _master() part of code from i2c-designware-core
> and i2c-designware-platdrv to separate functions.
> - Standardize all code related with MASTER modes.
>
Couple of comments, after addressing them
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> + if ((dev->master_cfg & DW_IC_CON_MASTER) &&
> + (dev->master_cfg & DW_IC_CON_SLAVE_DISABLE))
> + i2c_dw_configure_fifo_master(dev);
So, logically it's a part of slave patch.
For now it would be just
i2c_dw_configure_fifo_master(dev);
> +static irqreturn_t i2c_dw_isr(int this_irq, void *dev_id)
> +{
> + struct dw_i2c_dev *dev = dev_id;
> + u32 stat, enabled, mode;
mode is unused here, this is a part of slave patch either.
> +static void i2c_dw_configure_master(struct platform_device *pdev)
> +{
> + struct dw_i2c_dev *dev = platform_get_drvdata(pdev);
> + dev_info(&pdev->dev, "I am registed as a I2C Master!\n");
I don't want bikeshedding here, but the question just comes:
"Do we need to have this available via sysfs as a part of ABI?" So. user
space can check for / set a mode.
In any case this one is a separate story and another patch, here just to
make the message less annoying, it looks like dev_dbg() to me.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 0/5] i2c: designware: Add slave support Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-07 19:00 +0100
[PATCH v4 1/5] i2c: designware: Refactoring of the i2c-designware Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-07 19:00 +0100
Re: [PATCH v4 1/5] i2c: designware: Refactoring of the i2c-designware Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-12-07 20:00 +0100
[PATCH v4 3/5] i2c: designware: Add slave definitions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-07 19:00 +0100
Re: [PATCH v4 3/5] i2c: designware: Add slave definitions Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-12-07 20:20 +0100
[PATCH v4 2/5] i2c: designware: Master mode as separated driver Luis Oliveira <Luis.Oliveira@synopsys.com> - 2016-12-07 19:00 +0100
Re: [PATCH v4 2/5] i2c: designware: Master mode as separated driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-12-07 20:10 +0100
csiph-web