Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1537969

Re: [PATCH v2] drivers: net: cpsw-phy-sel: Clear RGMII_IDMODE on "rgmii" links

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH v2] drivers: net: cpsw-phy-sel: Clear RGMII_IDMODE on "rgmii" links
Date 2016-12-07 19:20 +0100
Message-ID <sLOYV-3At-21@gated-at.bofh.it> (permalink)
References <sLqWB-4tQ-13@gated-at.bofh.it> <sLOYV-3At-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Alexandru Gagniuc <alex.g@adaptrum.com>
Date: Tue,  6 Dec 2016 10:56:51 -0800

> Support for setting the RGMII_IDMODE bit was added in the commit
> referenced below. However, that commit did not add the symmetrical
> clearing of the bit by way of setting it in "mask". Add it here.
> 
> Note that the documentation marks clearing this bit as "reserved",
> however, according to TI, support for delaying the clock does exist in
> the MAC, although it is not officially supported.
> We tested this on a board with an RGMII to RGMII link that will not
> work unless this bit is cleared.
> 
> Fixes: 0fb26c3063ea ("drivers: net: cpsw-phy-sel: add support to configure rgmii internal delay")
> Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>

Applied.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH] drivers: net: cpsw-phy-sel: Clear RGMII_IDMODE on  "rgmii" links David Miller <davem@davemloft.net> - 2016-12-06 17:40 +0100
  Re: [PATCH v2] drivers: net: cpsw-phy-sel: Clear RGMII_IDMODE on  "rgmii" links David Miller <davem@davemloft.net> - 2016-12-07 19:20 +0100

csiph-web