Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1537965

Re: [PATCH 1/1 linux-next] ASoC: samsung: include gpio consumer.h

Show all headers | View raw

On Wed, Dec 07, 2016 at 08:39:02AM +0100, Fabian Frederick wrote:
> Fix the following build errors

I couldn't reproduce it on default config. Can you mention the necessary
environment/defconfig/arch etc.?

Patch itself looks needed. However shouldn't the driver depend also on
GPIOLIB?

Best regards,
Krzysztof

> sound/soc/samsung/tm2_wm5110.c:220:3: error: implicit declaration
> of function 'gpiod_set_value_cansleep' [-Werror=implicit-function-declaration]
> sound/soc/samsung/tm2_wm5110.c:438:24: error: implicit declaration
> of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  sound/soc/samsung/tm2_wm5110.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c
> index 5cdf7d1..24cc9d6 100644
> --- a/sound/soc/samsung/tm2_wm5110.c
> +++ b/sound/soc/samsung/tm2_wm5110.c
> @@ -12,6 +12,7 @@
>  
>  #include <linux/clk.h>
>  #include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
>  #include <sound/pcm_params.h>
> -- 
> 2.7.4
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1 linux-next] ASoC: samsung: include gpio consumer.h Fabian Frederick <fabf@skynet.be> - 2016-12-07 08:40 +0100
  Re: [PATCH 1/1 linux-next] ASoC: samsung: include gpio consumer.h Krzysztof Kozlowski <krzk@kernel.org> - 2016-12-07 19:00 +0100
    Re: [PATCH 1/1 linux-next] ASoC: samsung: include gpio consumer.h Fabian Frederick <fabf@skynet.be> - 2016-12-07 21:40 +0100
      Re: [PATCH 1/1 linux-next] ASoC: samsung: include gpio consumer.h Krzysztof Kozlowski <krzk@kernel.org> - 2016-12-08 18:50 +0100

csiph-web