Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1537882

Re: [net-next][PATCH v2 10/18] RDS: IB: track and log active side endpoint in connection

Show all headers | View raw

On 12/7/2016 7:53 AM, David Miller wrote:
> From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
> Date: Tue,  6 Dec 2016 20:01:48 -0800
>
>> @@ -181,6 +181,9 @@ struct rds_ib_connection {
>>
>>  	/* Batched completions */
>>  	unsigned int		i_unsignaled_wrs;
>> +
>> +	/* Endpoint role in connection */
>> +	int			i_active_side;
>>  };
>>
>  ...
>> @@ -685,6 +686,7 @@ int rds_ib_cm_initiate_connect(struct rdma_cm_id *cm_id)
>>  		if (ic->i_cm_id == cm_id)
>>  			ret = 0;
>>  	}
>> +	ic->i_active_side = true;
>>  	return ret;
>>  }
>>
>> @@ -859,6 +861,7 @@ void rds_ib_conn_path_shutdown(struct rds_conn_path *cp)
>>  	ic->i_sends = NULL;
>>  	vfree(ic->i_recvs);
>>  	ic->i_recvs = NULL;
>> +	ic->i_active_side = false;
>>  }
>>
>>  int rds_ib_conn_alloc(struct rds_connection *conn, gfp_t gfp)
>
> Use type "bool", not "int", for true/false values.
>
OK. Will fix it.

Regards,
Santosh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[net-next][PATCH v2 00/18] net: RDS updates Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 05:10 +0100
  [net-next][PATCH v2 02/18] RDS: mark few internal functions static to make sparse build happy Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 05:10 +0100
  [net-next][PATCH v2 01/18] RDS: log the address on bind failure Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 05:10 +0100
  [net-next][PATCH v2 15/18] RDS: add stat for socket recv memory usage Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 05:10 +0100
  [net-next][PATCH v2 10/18] RDS: IB: track and log active side endpoint in connection Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 05:10 +0100
    Re: [net-next][PATCH v2 10/18] RDS: IB: track and log active side  endpoint in connection David Miller <davem@davemloft.net> - 2016-12-07 17:00 +0100
      Re: [net-next][PATCH v2 10/18] RDS: IB: track and log active side  endpoint in connection Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 17:30 +0100
  [net-next][PATCH v2 12/18] RDS: IB: Add vector spreading for cqs Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 05:10 +0100
  [net-next][PATCH v2 03/18] RDS: IB: include faddr in connection log Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 05:10 +0100
  [net-next][PATCH v2 14/18] RDS: IB: fix panic due to handlers running post teardown Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-12-07 05:10 +0100

csiph-web