Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1537864

Re: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging

Show all headers | View raw

On Thu, Dec 01, 2016 at 04:41:26PM -0600, Stuart Yoder wrote:
> Move the source files out of staging into their final locations:
>   -include files in drivers/staging/fsl-mc/include go to include/linux/fsl
>   -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip
>   -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc
>   -README.txt, providing and overview of DPAA goes to
>    Documentation/dpaa2/overview.txt
>   -update MAINTAINERS with new location
> 
> Delete other remaining staging files-- Makefile, Kconfig, TODO

Ok, given that I haven't ever reviewed this code, I had a few questions
that I couldn't easily figure out by looking at your code:
	- what is the lifecycle of your 'struct device' usage?  Who
	  creates it, who frees it, and who accesses it?
	- do you have any Documentation/ABI entries?
	- root_dprc_count, why are you using an atomic variable for
	  this?  What is it for other than "look, I'm running!"?
	- don't call pr_info() in fsl_mc_bus_driver_init(), no need to
	  say anything if all goes well.  Same goes with random
	  dev_info() calls, please remove.

That's good enough for now, I think the answer to the first question is
going to cause more to come out :)

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 17:00 +0100
  RE: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging Stuart Yoder <stuart.yoder@nxp.com> - 2016-12-07 21:20 +0100
    Re: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging Greg KH <gregkh@linuxfoundation.org> - 2016-12-08 17:10 +0100
      RE: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging Stuart Yoder <stuart.yoder@nxp.com> - 2016-12-09 02:20 +0100
        Re: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging Greg KH <gregkh@linuxfoundation.org> - 2016-12-09 08:20 +0100
          RE: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging Stuart Yoder <stuart.yoder@nxp.com> - 2016-12-09 18:30 +0100

csiph-web