Re: [PATCH 3/3] powerpc: enable support for GCC plugins

From	Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] powerpc: enable support for GCC plugins
Date	2016-12-07 08:00 +0100
Message-ID	<sLEmS-4W7-19@gated-at.bofh.it> (permalink)
References	<sLhqh-6OF-7@gated-at.bofh.it> <sLhqh-6OF-13@gated-at.bofh.it> <sLvMC-7vq-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/12/16 08:25, Emese Revfy wrote:
> What are these missing headers? Because if they aren't necessary then they can
> be removed from gcc-common.h. There were missing headers on arm/arm64 and these
> archs are supported. I think this version check is unnecessary because
> gcc-plugin.sh also checks the missing headers.

rs6000-cpus.def, included via tm.h - see 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66840

I realise gcc-plugin.sh does detect this, but the point of the 
additional version check is to provide somewhat more helpful advice to 
the user.

> What is the problem on gcc-4.5/gcc-4.6?

On 4.6.4, c-family/c-common.h:

/scratch/ajd/gcc-test-v2/kernel/scripts/gcc-plugins/gcc-common.h:60:31: 
fatal error: c-family/c-common.h: No such file or directory

ajd@ka1:/scratch/ajd/tmp/cross/gcc-4.6.4-nolibc/powerpc64-linux$ find 
-name c-common.*
./lib/gcc/powerpc64-linux/4.6.4/plugin/include/c-common.h
./lib/gcc/powerpc64-linux/4.6.4/plugin/include/c-family/c-common.def

Are we sure the version check in gcc-common.h:59 is correct, or is this 
just a peculiarity of my particular toolchain?

I need to build another 4.5 toolchain, I'll try to do that this week.

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

Thread

[PATCH 1/3] gcc-plugins: fix definition of DISABLE_LATENT_ENTROPY_PLUGIN Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-12-06 07:30 +0100
  [PATCH 2/3] powerpc: correctly disable latent entropy GCC plugin on prom_init.o Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-12-06 07:30 +0100
  [PATCH 3/3] powerpc: enable support for GCC plugins Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-12-06 07:30 +0100
    Re: [PATCH 3/3] powerpc: enable support for GCC plugins Kees Cook <keescook@chromium.org> - 2016-12-06 21:50 +0100
      Re: [kernel-hardening] Re: [PATCH 3/3] powerpc: enable support for  GCC plugins Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-12-07 02:10 +0100
    Re: [PATCH 3/3] powerpc: enable support for GCC plugins Emese Revfy <re.emese@gmail.com> - 2016-12-06 22:50 +0100
      Re: [PATCH 3/3] powerpc: enable support for GCC plugins Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-12-07 08:00 +0100
    Re: [PATCH 3/3] powerpc: enable support for GCC plugins Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-12-07 06:50 +0100
    Re: [PATCH 3/3] powerpc: enable support for GCC plugins "PaX Team" <pageexec@freemail.hu> - 2016-12-08 16:40 +0100
      Re: [PATCH 3/3] powerpc: enable support for GCC plugins Kees Cook <keescook@chromium.org> - 2016-12-08 19:10 +0100
        Re: [PATCH 3/3] powerpc: enable support for GCC plugins Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-12-09 03:50 +0100
          Re: [PATCH 3/3] powerpc: enable support for GCC plugins "PaX Team" <pageexec@freemail.hu> - 2016-12-09 12:10 +0100

csiph-web