Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1536465

Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove

From "Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove
Date 2016-12-05 23:00 +0100
Message-ID <sL9sJ-1xT-7@gated-at.bofh.it> (permalink)
References <sISw2-1KH-27@gated-at.bofh.it>
Organization Oracle Corporation

Show all headers | View raw


>>>>> "John" == John Garry <john.garry@huawei.com> writes:

John> This patch addresses 4 problems in the module probe/remove:
John> - When hisi_sas_shost_alloc() fails after we alloc shost memory,
John> we should free shost memory before the function returns.
John> - When hisi_sas_probe() fails after we alloc the HBA memories,
John> we should also free the HBA memories.
John> - We should free shost memory at the end of hisi_sas_remove().
John> - sha->core.shost is set twice, so remove extra set.

Applied to 4.10/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] scsi: hisi_sas: fix free'ing in probe and remove John Garry <john.garry@huawei.com> - 2016-11-29 16:30 +0100
  Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove Quentin Lambert <lambert.quentin@gmail.com> - 2016-12-02 14:50 +0100
  Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-12-05 23:00 +0100

csiph-web