Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1536468

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

Show all headers | View raw

> On Dec 5, 2016, at 13:50, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> 
> On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote:
>> -	__u32 local_flags = 0;
>> +	u32 local_flags = 0;
> 
>> -	if (local_flags != 0) {
>> +	if (local_flags) {
> 
> Please avoid these unrelated white space changes.

Some projects (e.g. ext4 that I work with most) allow whitespace changes
as part of related changes to the code, since the code is being modified
anyway, and frown upon whitespace-only changes because they cause churn
in the code and otherwise introduce patch merge conflicts for relatively
minor benefits by themselves.

My preference is to allow whitespace cleanups in code being modified as
part of a patch that is making other fixes, since a few whitespace changes
don't typically make it any harder to review the patch.  If it gets so
far as moving blocks of code between files and this doesn't appear cleanly
in the patch then I'd ask for a separate patch.

Cheers, Andreas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] Fix ups to make lustre_idl.h a proper UAPI header James Simmons <jsimmons@infradead.org> - 2016-12-02 20:50 +0100
  [PATCH 5/6] staging: lustre: headers: Move functions out of lustre_idl.h James Simmons <jsimmons@infradead.org> - 2016-12-02 20:50 +0100
    Re: [PATCH 5/6] staging: lustre: headers: Move functions out of  lustre_idl.h Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-05 22:00 +0100
  [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions James Simmons <jsimmons@infradead.org> - 2016-12-02 20:50 +0100
    Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo  related functions Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-05 22:00 +0100
      Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a  header for obdo related functions "Dilger, Andreas" <andreas.dilger@intel.com> - 2016-12-05 23:00 +0100
        Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a  header for obdo related functions Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-05 23:10 +0100
          Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a  header for obdo related functions James Simmons <jsimmons@infradead.org> - 2016-12-07 20:50 +0100
    Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo  related functions Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-06 10:50 +0100
      Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo  related functions James Simmons <jsimmons@infradead.org> - 2016-12-07 20:20 +0100
  [PATCH 2/6] staging: lustre: headers: sort headers affected by swab move James Simmons <jsimmons@infradead.org> - 2016-12-02 20:50 +0100
    Re: [PATCH 2/6] staging: lustre: headers: sort headers affected by  swab move Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-06 10:40 +0100
  [PATCH 6/6] staging: lustre: headers: use proper byteorder functions in lustre_idl.h James Simmons <jsimmons@infradead.org> - 2016-12-02 20:50 +0100
  [PATCH 4/6] staging: lustre: headers: sort headers affected by obdo move James Simmons <jsimmons@infradead.org> - 2016-12-02 20:50 +0100
  [PATCH 1/6] staging: lustre: headers: move swab functions to new header files James Simmons <jsimmons@infradead.org> - 2016-12-02 20:50 +0100

csiph-web