Re: [PATCH 1/2] scsi: be2iscsi: set errno on error path

From	"Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] scsi: be2iscsi: set errno on error path
Date	2016-12-05 23:30 +0100
Message-ID	<sL9VL-20X-17@gated-at.bofh.it> (permalink)
References	<sKxGN-35u-3@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

>>>>> "Pan" == Pan Bian <bianpan201603@163.com> writes:

Pan> Variable ret is reset in the loop, and its value will be 0 during
Pan> the second and after repeat of the loop. If pci_alloc_consistent()
Pan> returns a NULL pointer then, it will leaves with return value 0. 0
Pan> means no error, which is contrary to the fact. This patches fixes
Pan> the bug, explicitly assigning "-ENOMEM" to return variable ret on
Pan> the path that the call to pci_alloc_consistent() fails.

Applied patches 1 and 2 to 4.10/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] scsi: be2iscsi: set errno on error path Pan Bian <bianpan201603@163.com> - 2016-12-04 06:40 +0100
  RE: [PATCH 1/2] scsi: be2iscsi: set errno on error path Jitendra Bhivare <jitendra.bhivare@broadcom.com> - 2016-12-05 04:30 +0100
  Re: [PATCH 1/2] scsi: be2iscsi: set errno on error path "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-12-05 23:30 +0100

csiph-web