Re: [PATCH 1/1] net: caif: remove ineffective check

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] net: caif: remove ineffective check
Date	2016-12-05 20:50 +0100
Message-ID	<sL7qV-hs-9@gated-at.bofh.it> (permalink)
References	<sKwrn-2oM-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Pan Bian <bianpan2016@163.com>
Date: Sun,  4 Dec 2016 12:15:44 +0800

> The check of the return value of sock_register() is ineffective.
> "if(!err)" seems to be a typo. It is better to propagate the error code
> to the callers of caif_sktinit_module(). This patch removes the check
> statment and directly returns the result of sock_register().
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751
> Signed-off-by: Pan Bian <bianpan2016@163.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] net: caif: remove ineffective check Pan Bian <bianpan2016@163.com> - 2016-12-04 05:20 +0100
  Re: [PATCH 1/1] net: caif: remove ineffective check David Miller <davem@davemloft.net> - 2016-12-05 20:50 +0100

csiph-web