Re: [PATCH 1/1] net: ethernet: broadcom: fix improper return value

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] net: ethernet: broadcom: fix improper return value
Date	2016-12-05 21:00 +0100
Message-ID	<sL7AB-kR-15@gated-at.bofh.it> (permalink)
References	<sKytb-3Dx-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Pan Bian <bianpan201604@163.com>
Date: Sun,  4 Dec 2016 14:29:29 +0800

> From: Pan Bian <bianpan2016@163.com>
> 
> Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate
> memory, and jumps to label "lbl" if the allocation fails. Label "lbl"
> first cleans memory and then returns variable rc. Before calling the
> macro, the value of variable rc is 0. Because 0 means no error, the
> callers of bnx2x_init_firmware() may be misled. This patch fixes the bug,
> assigning "-ENOMEM" to rc before calling macro NX2X_ALLOC_AND_SET().
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189141
> 
> Signed-off-by: Pan Bian <bianpan2016@163.com>

Applied, but...

> @@ -13505,6 +13505,7 @@ static int bnx2x_init_firmware(struct bnx2x *bp)
>  
>  	/* Initialize the pointers to the init arrays */
>  	/* Blob */
> +	rc = -ENOMEM;
>  	BNX2X_ALLOC_AND_SET(init_data, request_firmware_exit, be32_to_cpu_n);
>  
>  	/* Opcodes */

These kinds of macros which internally change control flow should always
be avoided.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] net: ethernet: broadcom: fix improper return value Pan Bian <bianpan201604@163.com> - 2016-12-04 07:30 +0100
  RE: [PATCH 1/1] net: ethernet: broadcom: fix improper return value "Kalderon, Michal" <Michal.Kalderon@cavium.com> - 2016-12-04 12:40 +0100
  Re: [PATCH 1/1] net: ethernet: broadcom: fix improper return value David Miller <davem@davemloft.net> - 2016-12-05 21:00 +0100

csiph-web