Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1536354

Re: [PATCH v8 1/3] perf annotate: Show raw form for jump instruction with indirect target

Show all headers | View raw

Em Mon, Dec 05, 2016 at 09:26:45PM +0530, Ravi Bangoria escreveu:
> For jump instructions that does not include target address as direct
> operand, show the original disassembled line for them. This is needed
> for certain powerpc jump instructions that use target address in a
> register (such as bctr, btar, ...).

Please, mention the name of the function where you copy annotated
examples from, so that I can reproduce it here, using the files you
provided (perf.data and vmlinux for powerpc).

Searching one such function now...
 
> Before:
>      ld     r12,32088(r12)
>      mtctr  r12
>   v  bctr   ffffffffffffca2c
>      std    r2,24(r1)
>      addis  r12,r2,-1
> 
> After:
>      ld     r12,32088(r12)
>      mtctr  r12
>   v  bctr
>      std    r2,24(r1)
>      addis  r12,r2,-1
> 
> Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> ---
> Changes in v8:
>   - v7: https://lkml.org/lkml/2016/9/21/436
>   - Rebase to acme/perf/core
>   - No logical changes. (Cross arch annotate patches are in. This patch
>     is for hardening annotate for powerpc.)
> 
>  tools/perf/util/annotate.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index 4012b1d..ea7e0de 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -237,6 +237,9 @@ static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *op
>  static int jump__scnprintf(struct ins *ins, char *bf, size_t size,
>  			   struct ins_operands *ops)
>  {
> +	if (!ops->target.addr)
> +		return ins__raw_scnprintf(ins, bf, size, ops);
> +
>  	return scnprintf(bf, size, "%-6.6s %" PRIx64, ins->name, ops->target.offset);
>  }
>  
> -- 
> 2.4.11

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v8 1/3] perf annotate: Show raw form for jump instruction with indirect target Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-12-05 17:00 +0100
  [PATCH v8 3/3] perf annotate: Fix jump target outside of function address range Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-12-05 17:00 +0100
  Re: [PATCH v8 1/3] perf annotate: Show raw form for jump instruction  with indirect target Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-05 20:30 +0100
  Re: [PATCH v8 1/3] perf annotate: Show raw form for jump instruction  with indirect target Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-05 21:30 +0100
    Re: [PATCH v8 1/3] perf annotate: Show raw form for jump instruction  with indirect target Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-05 21:40 +0100
  [tip:perf/core] perf annotate: Show raw form for jump instruction  with indirect target tip-bot for Ravi Bangoria <tipbot@zytor.com> - 2016-12-06 09:40 +0100

csiph-web