Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1536338

Re: [PATCH] SPCR: check bit width for the 16550 UART

From Duc Dang <dhdang@apm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] SPCR: check bit width for the 16550 UART
Date 2016-12-05 20:00 +0100
Message-ID <sL6Ex-8e2-5@gated-at.bofh.it> (permalink)
References <sL1bP-4Zh-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 5, 2016 at 5:05 AM, Aleksey Makarov
<aleksey.makarov@linaro.org> wrote:
> Check the 'Register Bit Width' field of the ACPI Generic Address
> Structure that specifies the address of the UART registers to
> decide if the driver should use "mmio32" access instead of "mmio".
>
> If the driver is other than 16550 the access with is defined
> by the Interface Type field of the SPCR table.
>
> For discussion:
>
> https://lkml.kernel.org/r/7fa523de-3fbb-1566-f521-927143f73d1e@redhat.com

Tested on X-Gene 1 and X-Gene 2 platforms.

Tested-by: Duc Dang <dhdang@apm.com>
>
> Signed-off-by: Aleksey Makarov <aleksey.makarov@linaro.org>
> Signed-off-by: Graeme Gregory <graeme.gregory@linaro.org>
> Reported-by: Heyi Guo <heyi.guo@linaro.org>
> ---
>  drivers/acpi/spcr.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
> index e8d7bc7..6c6710b 100644
> --- a/drivers/acpi/spcr.c
> +++ b/drivers/acpi/spcr.c
> @@ -70,6 +70,10 @@ int __init parse_spcr(bool earlycon)
>                 break;
>         case ACPI_DBG2_16550_COMPATIBLE:
>         case ACPI_DBG2_16550_SUBSET:
> +               if (table->serial_port.space_id ==
> +                       ACPI_ADR_SPACE_SYSTEM_MEMORY &&
> +                   table->serial_port.bit_width == 32)
> +                       iotype = "mmio32";
>                 uart = "uart";
>                 break;
>         default:
> --
> 2.10.2
>
Thanks,
Duc Dang.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] SPCR: check bit width for the 16550 UART Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-12-05 14:10 +0100
  Re: [PATCH] SPCR: check bit width for the 16550 UART Duc Dang <dhdang@apm.com> - 2016-12-05 20:00 +0100
    Re: [PATCH] SPCR: check bit width for the 16550 UART Jon Masters <jcm@redhat.com> - 2016-12-06 00:30 +0100
      Re: [PATCH] SPCR: check bit width for the 16550 UART Duc Dang <dhdang@apm.com> - 2016-12-06 01:00 +0100
        Re: [PATCH] SPCR: check bit width for the 16550 UART Jon Masters <jcm@redhat.com> - 2016-12-06 01:10 +0100
        Re: [PATCH] SPCR: check bit width for the 16550 UART Jon Masters <jcm@redhat.com> - 2016-12-06 01:10 +0100
        Re: [PATCH] SPCR: check bit width for the 16550 UART Duc Dang <dhdang@apm.com> - 2016-12-06 01:40 +0100
          Re: [PATCH] SPCR: check bit width for the 16550 UART Duc Dang <dhdang@apm.com> - 2016-12-06 05:00 +0100
            Re: [PATCH] SPCR: check bit width for the 16550 UART Jon Masters <jcm@redhat.com> - 2016-12-06 07:40 +0100
              Re: [PATCH] SPCR: check bit width for the 16550 UART Jon Masters <jcm@redhat.com> - 2016-12-06 08:00 +0100
                Re: [PATCH] SPCR: check bit width for the 16550 UART Jon Masters <jcm@redhat.com> - 2016-12-06 08:20 +0100
                Re: [PATCH] SPCR: check bit width for the 16550 UART Aleksey Makarov <aleksey.makarov@linaro.org> - 2016-12-06 09:50 +0100
              Re: [PATCH] SPCR: check bit width for the 16550 UART Mark Salter <msalter@redhat.com> - 2016-12-07 16:30 +0100

csiph-web