Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1536266

Re: [PATCH] Staging: comedi: kcomedilib: Add module_init/exit function

Show all headers | View raw

On 05/12/16 16:57, Cheah Kok Cheong wrote:
> Add init/exit function to follow LKM semantics.
> Apparently this module can still load/unload without
> the init/exit function.
>
> Tested loading/unloading with and without this patch.
>
> Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>
> ---
>  drivers/staging/comedi/kcomedilib/kcomedilib_main.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/staging/comedi/kcomedilib/kcomedilib_main.c b/drivers/staging/comedi/kcomedilib/kcomedilib_main.c
> index d0a8a28..55d43c0 100644
> --- a/drivers/staging/comedi/kcomedilib/kcomedilib_main.c
> +++ b/drivers/staging/comedi/kcomedilib/kcomedilib_main.c
> @@ -250,3 +250,15 @@ int comedi_get_n_channels(struct comedi_device *dev, unsigned int subdevice)
>  	return n;
>  }
>  EXPORT_SYMBOL_GPL(comedi_get_n_channels);
> +
> +static int __init kcomedilib_module_init(void)
> +{
> +	return 0;
> +}
> +
> +static void __exit kcomedilib_module_exit(void)
> +{
> +}
> +
> +module_init(kcomedilib_module_init);
> +module_exit(kcomedilib_module_exit);
>

Looks good, thanks!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: comedi: kcomedilib: Add module_init/exit function Cheah Kok Cheong <thrust73@gmail.com> - 2016-12-05 18:00 +0100
  Re: [PATCH] Staging: comedi: kcomedilib: Add module_init/exit  function Ian Abbott <abbotti@mev.co.uk> - 2016-12-05 18:40 +0100

csiph-web