Re: [PATCHv3] zram: restrict add/remove attributes to root only

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCHv3] zram: restrict add/remove attributes to root only
Date	2016-12-05 18:00 +0100
Message-ID	<sL4Mp-71m-21@gated-at.bofh.it> (permalink)
References	<sKEoW-7ek-7@gated-at.bofh.it> <sL3Qm-6ow-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 06, 2016 at 12:58:45AM +0900, Sergey Senozhatsky wrote:
> zram hot_add sysfs attribute is a very 'special' attribute - reading
> from it creates a new uninitialized zram device. This file, by a mistake,
> can be read by a 'normal' user at the moment, while only root must be
> able to create a new zram device, therefore hot_add attribute must have
> S_IRUSR mode, not S_IRUGO.
> 
> Fixes: 6566d1a32bf72 ("zram: add dynamic device add/remove functionality")
> Reported-by: Steven Allen <steven@stebalien.com>
> Cc: <stable@vger.kernel.org>    [4.2+]
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2] zram: restrict add/remove attributes to root only Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-12-04 13:50 +0100
  Re: [PATCHv2] zram: restrict add/remove attributes to root only Greg KH <gregkh@linuxfoundation.org> - 2016-12-05 14:00 +0100
    Re: [PATCHv2] zram: restrict add/remove attributes to root only Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-12-05 17:00 +0100
  [PATCHv3] zram: restrict add/remove attributes to root only Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-12-05 17:00 +0100
    Re: [PATCHv3] zram: restrict add/remove attributes to root only Greg KH <gregkh@linuxfoundation.org> - 2016-12-05 18:00 +0100

csiph-web