Re: [PATCH 09/18] arm64: introduce binfmt_elf32.c

From	Catalin Marinas <catalin.marinas@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/18] arm64: introduce binfmt_elf32.c
Date	2016-12-05 16:20 +0100
Message-ID	<sL3dD-6bD-3@gated-at.bofh.it> (permalink)
References	<svVUK-5lu-13@gated-at.bofh.it> <sL3dD-6bD-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 21, 2016 at 11:33:08PM +0300, Yury Norov wrote:
> As we support more than one compat formats, it looks more reasonable
> to not use fs/compat_binfmt.c. Custom binfmt_elf32.c allows to move aarch32
> specific definitions there and make code more maintainable and readable.

Can you remind me why we need this patch (rather than using the default
fs/compat_binfmt_elf.c which you include here anyway)?

> --- /dev/null
> +++ b/arch/arm64/kernel/binfmt_elf32.c
> @@ -0,0 +1,31 @@
> +/*
> + * Support for AArch32 Linux ELF binaries.
> + */
> +
> +/* AArch32 EABI. */
> +#define EF_ARM_EABI_MASK		0xff000000
> +
> +#define compat_start_thread		compat_start_thread
> +#define COMPAT_SET_PERSONALITY(ex)		\
> +do {						\
> +	clear_thread_flag(TIF_32BIT_AARCH64);	\
> +	set_thread_flag(TIF_32BIT);		\
> +} while (0)

You introduce this here but it seems to still be present in asm/elf.h.

-- 
Catalin

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 09/18] arm64: introduce binfmt_elf32.c Catalin Marinas <catalin.marinas@arm.com> - 2016-12-05 16:20 +0100

csiph-web