Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1536137
| From | Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes |
| Date | 2016-12-05 15:50 +0100 |
| Message-ID | <sL2KB-5N1-11@gated-at.bofh.it> (permalink) |
| References | <sHq8N-1SA-13@gated-at.bofh.it> <sHq8N-1SA-19@gated-at.bofh.it> <sL1Ox-5co-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Hans,
On Monday 05 Dec 2016 14:44:55 Hans Verkuil wrote:
> > +static int video_querycap(struct file *file, void *fh,
> > + struct v4l2_capability *cap)
> > +{
> > + strlcpy(cap->driver, "qcom-camss", sizeof(cap->driver));
> > + strlcpy(cap->card, "Qualcomm Camera Subsystem", sizeof(cap->card));
> > + strlcpy(cap->bus_info, "platform:qcom-camss",
> > sizeof(cap->bus_info));
> > + cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING |
> > + V4L2_CAP_DEVICE_CAPS
> > ;
> > + cap->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
>
> Don't set capabilities and device_caps here. Instead fill in the struct
> video_device device_caps field and the v4l2 core will take care of
> cap->capabilities and cap->device_caps.
Time to add this to checkpatch.pl ? :-)
> > +
> > + return 0;
> > +}
--
Regards,
Laurent Pinchart
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 02/10] MAINTAINERS: Add Qualcomm Camera subsystem driver Todor Tomov <todor.tomov@linaro.org> - 2016-11-25 16:00 +0100
[PATCH 08/10] media: camss: Add files which handle the video device nodes Todor Tomov <todor.tomov@linaro.org> - 2016-11-25 16:00 +0100
Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes Hans Verkuil <hverkuil@xs4all.nl> - 2016-12-05 14:50 +0100
Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-05 15:50 +0100
Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-05 16:00 +0100
Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes Hans Verkuil <hverkuil@xs4all.nl> - 2016-12-05 16:10 +0100
Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-05 16:30 +0100
Re: [PATCH 08/10] media: camss: Add files which handle the video device nodes Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-05 16:30 +0100
[PATCH 04/10] media: camss: Add CSIPHY files Todor Tomov <todor.tomov@linaro.org> - 2016-11-25 16:00 +0100
[PATCH 03/10] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document Todor Tomov <todor.tomov@linaro.org> - 2016-11-25 16:00 +0100
[PATCH 06/10] media: camss: Add ISPIF files Todor Tomov <todor.tomov@linaro.org> - 2016-11-25 16:00 +0100
[PATCH 09/10] media: camms: Add core files Todor Tomov <todor.tomov@linaro.org> - 2016-11-25 16:00 +0100
[PATCH 05/10] media: camss: Add CSID files Todor Tomov <todor.tomov@linaro.org> - 2016-11-25 16:00 +0100
csiph-web